From: "Cédric Le Goater" <clg@kaod.org>
To: Aditya Gupta <adityag@linux.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Subject: Re: [PATCH v2 06/10] ppc/pnv: Add OCC for Power11
Date: Fri, 26 Apr 2024 16:33:13 +0200 [thread overview]
Message-ID: <71cc400b-0c24-4f55-874e-9e0dd39ee55c@kaod.org> (raw)
In-Reply-To: <20240426110023.733309-7-adityag@linux.ibm.com>
On 4/26/24 13:00, Aditya Gupta wrote:
> Power11 core is same as Power10, reuse PNV10_OCC initialisation,
> by declaring `PNV11_OCC` as child class of `PNV10_OCC`
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: Frédéric Barrat <fbarrat@linux.ibm.com>
> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
> Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> ---
> hw/ppc/pnv_occ.c | 14 ++++++++++++++
> include/hw/ppc/pnv_occ.h | 2 ++
> 2 files changed, 16 insertions(+)
>
> diff --git a/hw/ppc/pnv_occ.c b/hw/ppc/pnv_occ.c
> index 48123ceae176..4f510419045e 100644
> --- a/hw/ppc/pnv_occ.c
> +++ b/hw/ppc/pnv_occ.c
> @@ -262,6 +262,19 @@ static const TypeInfo pnv_occ_power10_type_info = {
> .class_init = pnv_occ_power10_class_init,
> };
>
> +static void pnv_occ_power11_class_init(ObjectClass *klass, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + dc->desc = "PowerNV OCC Controller (POWER11)";
> +}
> +
> +static const TypeInfo pnv_occ_power11_type_info = {
> + .name = TYPE_PNV11_OCC,
> + .parent = TYPE_PNV10_OCC,
> + .class_init = pnv_occ_power11_class_init,
> +};
> +
> static void pnv_occ_realize(DeviceState *dev, Error **errp)
> {
> PnvOCC *occ = PNV_OCC(dev);
> @@ -305,6 +318,7 @@ static void pnv_occ_register_types(void)
> type_register_static(&pnv_occ_power8_type_info);
> type_register_static(&pnv_occ_power9_type_info);
> type_register_static(&pnv_occ_power10_type_info);
> + type_register_static(&pnv_occ_power11_type_info);
> }
>
> type_init(pnv_occ_register_types);
> diff --git a/include/hw/ppc/pnv_occ.h b/include/hw/ppc/pnv_occ.h
> index df321244e3b1..7b5e28f13b4f 100644
> --- a/include/hw/ppc/pnv_occ.h
> +++ b/include/hw/ppc/pnv_occ.h
> @@ -34,6 +34,8 @@ DECLARE_INSTANCE_CHECKER(PnvOCC, PNV9_OCC,
> TYPE_PNV9_OCC)
> #define TYPE_PNV10_OCC TYPE_PNV_OCC "-POWER10"
> DECLARE_INSTANCE_CHECKER(PnvOCC, PNV10_OCC, TYPE_PNV10_OCC)
> +#define TYPE_PNV11_OCC TYPE_PNV_OCC "-POWER11"
> +DECLARE_INSTANCE_CHECKER(PnvOCC, PNV11_OCC, TYPE_PNV11_OCC)
>
> #define PNV_OCC_SENSOR_DATA_BLOCK_OFFSET 0x00580000
> #define PNV_OCC_SENSOR_DATA_BLOCK_SIZE 0x00025800
next prev parent reply other threads:[~2024-04-26 14:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 11:00 [PATCH v2 00/10] Power11 support for QEMU Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 01/10] ppc/pseries: Add Power11 cpu type Aditya Gupta
2024-04-26 14:27 ` Cédric Le Goater
2024-04-26 17:05 ` Aditya Gupta
2024-04-26 17:41 ` Cédric Le Goater
2024-05-01 13:22 ` Aditya Gupta
2024-05-01 14:39 ` Aditya Gupta
2024-04-26 17:12 ` Aditya Gupta
2024-04-26 17:28 ` Cédric Le Goater
2024-04-26 17:44 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 02/10] ppc/pnv: Introduce 'PnvChipClass::chip_type' Aditya Gupta
2024-04-26 14:16 ` Cédric Le Goater
2024-04-26 17:18 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 03/10] ppc/pnv: Add a Power11 Pnv11Chip, and a Power11 Machine Aditya Gupta
2024-04-26 14:55 ` Cédric Le Goater
2024-04-26 17:34 ` Aditya Gupta
2024-04-26 17:53 ` Cédric Le Goater
2024-05-01 13:28 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 04/10] ppc/pnv: Add HOMER for POWER11 Aditya Gupta
2024-04-26 14:32 ` Cédric Le Goater
2024-04-26 17:38 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 05/10] ppc/pnv: Add a LPC controller " Aditya Gupta
2024-04-26 14:32 ` Cédric Le Goater
2024-04-26 17:38 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 06/10] ppc/pnv: Add OCC for Power11 Aditya Gupta
2024-04-26 14:33 ` Cédric Le Goater [this message]
2024-04-26 17:38 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 07/10] ppc/pnv: Add a PSI bridge model " Aditya Gupta
2024-04-26 14:33 ` Cédric Le Goater
2024-04-26 17:39 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 08/10] ppc/pnv: Add SBE " Aditya Gupta
2024-04-26 14:33 ` Cédric Le Goater
2024-04-26 17:39 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 09/10] ppc: Make Power11 as default cpu type for 'pseries' and 'powernv' Aditya Gupta
2024-04-26 14:32 ` Cédric Le Goater
2024-04-26 17:40 ` Aditya Gupta
2024-04-29 1:44 ` David Gibson
2024-05-01 13:29 ` Aditya Gupta
2024-05-03 4:52 ` Nicholas Piggin
2024-05-03 6:53 ` Aditya Gupta
2024-04-26 11:00 ` [PATCH v2 10/10] ppc/pnv: Update skiboot.lid to support Power11 Aditya Gupta
2024-04-26 14:38 ` Cédric Le Goater
2024-04-26 17:42 ` Aditya Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cc400b-0c24-4f55-874e-9e0dd39ee55c@kaod.org \
--to=clg@kaod.org \
--cc=adityag@linux.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=maddy@linux.ibm.com \
--cc=mahesh@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).