From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com,
bmeng@tinylab.org, liwei1518@gmail.com,
zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com,
richard.henderson@linaro.org, philmd@linaro.org,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Subject: [PATCH v11 0/7] riscv: set vstart_eq_zero on vector insns
Date: Mon, 11 Mar 2024 10:58:48 -0300 [thread overview]
Message-ID: <20240311135855.225578-1-dbarboza@ventanamicro.com> (raw)
Hi,
In this new version, after the comments from LIU Zhiwei in v9 [1], I
decided to ditch all the patches that were trying to integrate the tail
update process in a single function. Handling the right value for NF for
every single function is out of the scope for this bug fix. The patches
might be useful in the future if we decide that such integration adds
value, but for now it's too much.
For this bug fix I decided to bring a sledgehammer and inserted an early
exist in every vector helper if vstart >= vl. This will make the whole
helper a no-op if vstart is out of bounds, and make it trivial for us to
proceed with removing brconds and so on.
I also took the opportunity to fix the flag name in patch 9 from v10,
now patch 6.
Series based on master.
Patches missing review: patch 3
Changes from v10:
- patches 2, 3, 4, 5 from v10: dropped
- patch 3 (new):
- do an early exit in vector helpers if vstart >= vl
- patch 6 (former patch 9):
- fix 'vstart_qe_zero' commit msg references to 'vstart_eq_zero'
- v10 link: https://lore.kernel.org/qemu-riscv/20240310115315.187283-1-dbarboza@ventanamicro.com/
Daniel Henrique Barboza (6):
target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX()
trans_rvv.c.inc: set vstart = 0 in int scalar move insns
target/riscv/vector_helpers: do early exit when vstart >= vl
target/riscv: remove 'over' brconds from vector trans
trans_rvv.c.inc: remove redundant mark_vs_dirty() calls
target/riscv/vector_helper.c: optimize loops in ldst helpers
Ivan Klokov (1):
target/riscv: enable 'vstart_eq_zero' in the end of insns
target/riscv/insn_trans/trans_rvbf16.c.inc | 18 +-
target/riscv/insn_trans/trans_rvv.c.inc | 198 +++++----------------
target/riscv/insn_trans/trans_rvvk.c.inc | 30 +---
target/riscv/translate.c | 6 +
target/riscv/vcrypto_helper.c | 32 ++++
target/riscv/vector_helper.c | 97 +++++++++-
target/riscv/vector_internals.c | 4 +
target/riscv/vector_internals.h | 9 +
8 files changed, 202 insertions(+), 192 deletions(-)
--
2.43.2
next reply other threads:[~2024-03-11 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:58 Daniel Henrique Barboza [this message]
2024-03-11 13:58 ` [PATCH v11 1/7] target/riscv/vector_helper.c: set vstart = 0 in GEN_VEXT_VSLIDEUP_VX() Daniel Henrique Barboza
2024-03-11 13:58 ` [PATCH v11 2/7] trans_rvv.c.inc: set vstart = 0 in int scalar move insns Daniel Henrique Barboza
2024-03-11 13:58 ` [PATCH v11 3/7] target/riscv/vector_helpers: do early exit when vstart >= vl Daniel Henrique Barboza
2024-03-11 17:13 ` Richard Henderson
2024-03-11 13:58 ` [PATCH v11 4/7] target/riscv: remove 'over' brconds from vector trans Daniel Henrique Barboza
2024-03-11 17:15 ` Richard Henderson
2024-03-11 13:58 ` [PATCH v11 5/7] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls Daniel Henrique Barboza
2024-03-11 13:58 ` [PATCH v11 6/7] target/riscv: enable 'vstart_eq_zero' in the end of insns Daniel Henrique Barboza
2024-03-11 13:58 ` [PATCH v11 7/7] target/riscv/vector_helper.c: optimize loops in ldst helpers Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311135855.225578-1-dbarboza@ventanamicro.com \
--to=dbarboza@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=liwei1518@gmail.com \
--cc=palmer@rivosinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).