From: Alexey Baturo <baturo.alexey@gmail.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: liwei <liwei1518@gmail.com>,
richard.henderson@linaro.org, space.monkey.delivers@gmail.com,
palmer@dabbelt.com, Alistair.Francis@wdc.com,
sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0
Date: Tue, 14 May 2024 19:08:13 +0300 [thread overview]
Message-ID: <CAFukJ-D9SMJUoSDOf5us5QXY2VM79Xbi=siy7obOo42B3fLxXg@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKMtJPGXs+rXFzfN7jqYTMbKBQ2SYVYoQ5kONT-FKkp=9g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]
>The cover letter says that this implements version 1.0 of the spec, this
sounds like it doesn't.
Yeah, sorry about the confusion. Yes, the patch is actually for v0.8 but as
you've correctly mentioned v0.8 has not so much differences to v1.0.
> Instead of constantly removing and re-adding the code
I was talking about only one removing the existing code and replacing it
with current patches and then making updates on top of them.
>Do you mind fixing that and addressing the other comments/concerns
Sure
пн, 13 мая 2024 г. в 14:32, Alistair Francis <alistair23@gmail.com>:
> On Mon, May 13, 2024 at 9:14 PM Alistair Francis <alistair23@gmail.com>
> wrote:
> >
> > On Mon, May 13, 2024 at 9:05 PM Alexey Baturo <baturo.alexey@gmail.com>
> wrote:
> > >
> > > Hi,
> > >
> > > > Hi, any change from v0.8 to v1.0?
> > > Not in the patches that were sent. I'd still suggest applying a
> step-by-step approach with cleaning up old code and establishing the new
> mechanisms first and then updating the code to match the spec 100%. Also I
> heard Martin has some arch compliance tests for J-ext somewhere.
> >
> > The cover letter says that this implements version 1.0 of the spec,
> > this sounds like it doesn't.
> >
> > Also, it's better to make the changes on top of the current code.
> > Instead of constantly removing and re-adding the code. Which is then
> > hard to review. Especially as I'm guessing there isn't a huge
> > difference between v0.8 and v1.0.
> >
> > > @Alistair Francis @liwei does this approach sound reasonable to you?
> > >
> > > >Also, this needs another rebase
> > > Sure, no problem at all. I'll rebase and re-send them later today.
>
> Sorry, it did apply correctly! That was my mistake.
>
> But this series generates a warning. Do you mind fixing that and
> addressing the other comments/concerns
>
> Alistair
>
> >
> > Thanks. Can you be very clear which version of the spec you have
> > developed and tested against as well.
> >
> > Alistair
>
[-- Attachment #2: Type: text/html, Size: 2720 bytes --]
next prev parent reply other threads:[~2024-05-14 16:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 10:10 [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0 Alexey Baturo
2024-05-11 10:10 ` [PATCH v9 1/6] target/riscv: Remove obsolete pointer masking extension code Alexey Baturo
2024-05-11 10:10 ` [PATCH v9 2/6] target/riscv: Add new CSR fields for S{sn, mn, m}pm extensions as part of Zjpm v0.8 Alexey Baturo
2024-05-11 14:16 ` liwei
2024-05-13 11:29 ` Alistair Francis
2024-06-02 23:00 ` Daniel Henrique Barboza
2024-05-11 10:10 ` [PATCH v9 3/6] target/riscv: Add helper functions to calculate current number of masked bits for pointer masking Alexey Baturo
2024-05-13 12:11 ` LIU Zhiwei
2024-05-13 12:35 ` LIU Zhiwei
2024-05-13 12:39 ` LIU Zhiwei
2024-05-11 10:10 ` [PATCH v9 4/6] target/riscv: Add pointer masking tb flags Alexey Baturo
2024-05-13 12:13 ` LIU Zhiwei
2024-05-11 10:10 ` [PATCH v9 5/6] target/riscv: Update address modify functions to take into account pointer masking Alexey Baturo
2024-05-13 12:46 ` LIU Zhiwei
2024-05-11 10:10 ` [PATCH v9 6/6] target/riscv: Enable updates for pointer masking variables and thus enable pointer masking extension Alexey Baturo
2024-05-13 12:48 ` LIU Zhiwei
2024-05-11 13:56 ` [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0 liwei
2024-05-13 10:24 ` Alistair Francis
2024-05-13 11:05 ` Alexey Baturo
2024-05-13 11:14 ` Alistair Francis
2024-05-13 11:32 ` Alistair Francis
2024-05-14 16:08 ` Alexey Baturo [this message]
2024-05-13 12:50 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFukJ-D9SMJUoSDOf5us5QXY2VM79Xbi=siy7obOo42B3fLxXg@mail.gmail.com' \
--to=baturo.alexey@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
--cc=space.monkey.delivers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).