From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Weiwei Li <liwei1518@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device
Date: Sat, 13 Apr 2024 11:50:51 +0200 [thread overview]
Message-ID: <a6bb2e1d-ef8e-446e-b898-5ddf13cd66b0@linaro.org> (raw)
In-Reply-To: <12d6a650-a0a9-4e25-9ad1-68aa03064794@redhat.com>
On 12/4/24 11:15, Thomas Huth wrote:
> On 12/04/2024 08.20, Thomas Huth wrote:
>> The cpu-cluster device is only needed for some few arm and riscv
>> machines. Let's avoid compiling and linking it if it is not really
>> necessary.
I expect clustering become the new default for heterogeneous machines,
but we are not there yet.
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> hw/arm/Kconfig | 3 +++
>> hw/cpu/Kconfig | 3 +++
>> hw/cpu/meson.build | 2 +-
>> hw/riscv/Kconfig | 2 ++
>> 4 files changed, 9 insertions(+), 1 deletion(-)
>> diff --git a/hw/cpu/meson.build b/hw/cpu/meson.build
>> index 38cdcfbe57..43a34c4c6e 100644
>> --- a/hw/cpu/meson.build
>> +++ b/hw/cpu/meson.build
>> @@ -1,4 +1,4 @@
>> -system_ss.add(files('core.c', 'cluster.c'))
>> +system_ss.add(when: 'CONFIG_CPU_CLUSTER', if_true: files('core.c',
>> 'cluster.c'))
>
> Oops, sorry, the switch should only be used for cluster.c, not for
> core.c. I'll change it in v2 ...
For v2:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2024-04-13 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:20 [PATCH 0/2] Improvements for switches in hw/cpu/Kconfig Thomas Huth
2024-04-12 6:20 ` [PATCH 1/2] hw: Fix problem with the A*MPCORE switches in the Kconfig files Thomas Huth
2024-04-12 11:10 ` Philippe Mathieu-Daudé
2024-04-12 11:32 ` Thomas Huth
2024-04-13 9:48 ` Philippe Mathieu-Daudé
2024-04-12 6:20 ` [PATCH 2/2] hw: Add a Kconfig switch for the TYPE_CPU_CLUSTER device Thomas Huth
2024-04-12 9:15 ` Thomas Huth
2024-04-13 9:50 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6bb2e1d-ef8e-446e-b898-5ddf13cd66b0@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).