From: Shawn Anastasio <sanastasio@raptorengineering.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Alistair Francis <alistair.francis@wdc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Connor Davis <connojdavis@gmail.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH for-4.19] ppc/riscv: fix arch_acquire_resource_check()
Date: Sun, 5 May 2024 17:12:57 -0500 [thread overview]
Message-ID: <212940fc-4e3f-4763-934f-c8306d44ad7e@raptorengineering.com> (raw)
In-Reply-To: <20240430153423.80875-1-roger.pau@citrix.com>
Hi Roger,
On 4/30/24 10:34 AM, Roger Pau Monne wrote:
> None of the implementations support set_foreign_p2m_entry() yet, neither they
> have a p2m walk in domain_relinquish_resources() in order to remove the foreign
> mappings from the p2m and thus drop the extra refcounts.
>
> Adjust the arch helpers to return false and introduce a comment that clearly
> states it is not only taking extra refcounts that's needed, but also dropping
> them on domain teardown.
>
> Fixes: 4988704e00d8 ('xen/riscv: introduce p2m.h')
> Fixes: 4a2f68f90930 ('xen/ppc: Define minimal stub headers required for full build')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
This makes sense to me. This stub implementation was definitely an
oversight on my part.
Acked-by: Shawn Anastasio <sanastasio@raptorengineering.com>
Thanks,
Shawn
prev parent reply other threads:[~2024-05-05 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:34 [PATCH for-4.19] ppc/riscv: fix arch_acquire_resource_check() Roger Pau Monne
2024-05-02 7:23 ` Jan Beulich
2024-05-02 7:35 ` Roger Pau Monné
2024-05-02 8:46 ` Oleksii
2024-05-02 10:31 ` Roger Pau Monné
2024-05-05 22:12 ` Shawn Anastasio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=212940fc-4e3f-4763-934f-c8306d44ad7e@raptorengineering.com \
--to=sanastasio@raptorengineering.com \
--cc=alistair.francis@wdc.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).