From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Oleksii <oleksii.kurochko@gmail.com>
Cc: xen-devel@lists.xenproject.org,
Shawn Anastasio <sanastasio@raptorengineering.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH for-4.19] ppc/riscv: fix arch_acquire_resource_check()
Date: Thu, 2 May 2024 12:31:06 +0200 [thread overview]
Message-ID: <ZjNraq889KamBWfE@macbook> (raw)
In-Reply-To: <2cabc6a1448c6f18cab963bc463347f088d643dd.camel@gmail.com>
On Thu, May 02, 2024 at 10:46:12AM +0200, Oleksii wrote:
> On Tue, 2024-04-30 at 17:34 +0200, Roger Pau Monne wrote:
> > None of the implementations support set_foreign_p2m_entry() yet,
> > neither they
> > have a p2m walk in domain_relinquish_resources() in order to remove
> > the foreign
> > mappings from the p2m and thus drop the extra refcounts.
> >
> > Adjust the arch helpers to return false and introduce a comment that
> > clearly
> > states it is not only taking extra refcounts that's needed, but also
> > dropping
> > them on domain teardown.
> I am okay with such adjustment for now as it is more safe and nothing
> will be missed during implementation of p2m, but I am curious how then
> Arm handles that, their implementation is also just returns true. ( I
> planned to have p2m implementation similar to Arm )
Arm does have an implementation of set_foreign_p2m_entry() and
domain_relinquish_resources() that handle foreign mappings correctly.
>
> Anyway, based on that it safer for RISC-V:
> Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Thanks, Roger.
next prev parent reply other threads:[~2024-05-02 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 15:34 [PATCH for-4.19] ppc/riscv: fix arch_acquire_resource_check() Roger Pau Monne
2024-05-02 7:23 ` Jan Beulich
2024-05-02 7:35 ` Roger Pau Monné
2024-05-02 8:46 ` Oleksii
2024-05-02 10:31 ` Roger Pau Monné [this message]
2024-05-05 22:12 ` Shawn Anastasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjNraq889KamBWfE@macbook \
--to=roger.pau@citrix.com \
--cc=alistair.francis@wdc.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sanastasio@raptorengineering.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).