* [PATCH 0/3] misc cleanups
@ 2016-12-29 7:42 5% Eric Wong
2016-12-29 7:42 7% ` [PATCH 2/3] use opt_str_freeze to avoid allocations in a few places Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2016-12-29 7:42 UTC (permalink / raw)
To: mogilefs-client-public
Nothing earth shattering, just 3 cleanups while I noticed
while working on other stuff...
3 changes:
avoid pointless capture in regexp
use opt_str_freeze to avoid allocations in a few places
new_file/common: simplify empty class declarations
lib/mogilefs/http_file.rb | 2 +-
lib/mogilefs/new_file/common.rb | 12 ++++++------
lib/mogilefs/new_file/stream.rb | 8 ++++----
lib/mogilefs/new_file/writer.rb | 2 +-
4 files changed, 12 insertions(+), 12 deletions(-)
^ permalink raw reply [relevance 5%]
* [ANN] mogilefs-client 3.11.0 - MogileFS client library for Ruby
@ 2017-01-31 18:38 5% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2017-01-31 18:38 UTC (permalink / raw)
To: ruby-talk, mogile; +Cc: mogilefs-client-public
A MogileFS client library for Ruby. MogileFS is an open source
distributed filesystem, see: http://mogilefs.org/ for more details.
This library allows any Ruby application to read, write and delete
files in a MogileFS instance.
Changes:
This release provides compatibility with net-http-persistent 3.x
while retaining support for the (API-incompatible) 2.x series.
Users of mainline Ruby 2.2+ get a workaround for excessive
garbage for uploading files. This excessive garbage on IO#write
should be fixed when Ruby 2.5 gets released on Dec 25, 2017:
https://bugs.ruby-lang.org/issues/13085
There's also a few minor garbage reductions of small strings,
relying on the maintained cmogstored for Content-Range PUT
testing, and some minor build system and documentation updates.
12 changes since 3.10.0 (Aug 2016):
avoid pointless capture in regexp
use opt_str_freeze to avoid allocations in a few places
new_file/common: simplify empty class declarations
support net-http-persistent 3.x
test: switch to cmogstored for testing Content-Range PUTs
avoid excessive garbage on uploads with Ruby 2.2+
socket_common: limit IO#write garbage workaround to <= 2.4
freeze string literals in a few more places
update URLS to HTTPS
README: explain removal of NFS support
doc: remove private email address linkage
gemspec: remove olddoc development dependency
rdoc :: https://bogomips.org/mogilefs-client/
feed :: https://bogomips.org/mogilefs-client/NEWS.atom.xml
list :: mogilefs-client-public@bogomips.org
list-cc :: mogile@googlegroups.com
list-archive :: https://bogomips.org/mogilefs-client-public/
git clone git://bogomips.org/mogilefs-client.git
nntp://news.public-inbox.org/inbox.comp.file-systems.mogilefs.ruby
^ permalink raw reply [relevance 5%]
* [PATCH 2/3] use opt_str_freeze to avoid allocations in a few places
2016-12-29 7:42 5% [PATCH 0/3] misc cleanups Eric Wong
@ 2016-12-29 7:42 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2016-12-29 7:42 UTC (permalink / raw)
To: mogilefs-client-public
None of these are too performance critical, but err on
the safe side and avoid allocations whenever possible.
---
lib/mogilefs/http_file.rb | 2 +-
lib/mogilefs/new_file/stream.rb | 8 ++++----
lib/mogilefs/new_file/writer.rb | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/mogilefs/http_file.rb b/lib/mogilefs/http_file.rb
index caf85ca..c7949a5 100644
--- a/lib/mogilefs/http_file.rb
+++ b/lib/mogilefs/http_file.rb
@@ -143,7 +143,7 @@ def nhp_put(devid, uri)
end
put = Net::HTTP::Put.new(uri.path)
- put["Content-Type"] = "application/octet-stream"
+ put["Content-Type"] = "application/octet-stream".freeze
if md5 = @opts[:content_md5]
if md5.respond_to?(:call)
md5 = md5.call.strip
diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb
index 71ac591..195b121 100644
--- a/lib/mogilefs/new_file/stream.rb
+++ b/lib/mogilefs/new_file/stream.rb
@@ -66,7 +66,7 @@ def commit
def start_sock(sock, uri)
host_with_port = "#{uri.host}:#{uri.port}"
headers = "PUT #{uri.request_uri} HTTP/1.1\r\n" \
- "Host: #{host_with_port}\r\n" \
+ "Host: #{host_with_port}\r\n"
content_md5 = @opts[:content_md5]
if String === content_md5
@@ -75,16 +75,16 @@ def start_sock(sock, uri)
:trailer == content_md5 ||
MD5_TRAILER_NODES[host_with_port]
@md5 = Digest::MD5.new
- headers << "Trailer: Content-MD5\r\n"
+ headers << "Trailer: Content-MD5\r\n".freeze
end
if ! @md5 && clen = @opts[:content_length]
headers << "Content-Length: #{clen}\r\n"
else
- headers << "Transfer-Encoding: chunked\r\n"
+ headers << "Transfer-Encoding: chunked\r\n".freeze
end
- sock.write(headers << "\r\n")
+ sock.write(headers << "\r\n".freeze)
end
alias syswrite write
diff --git a/lib/mogilefs/new_file/writer.rb b/lib/mogilefs/new_file/writer.rb
index d58a4e6..e2f13fc 100644
--- a/lib/mogilefs/new_file/writer.rb
+++ b/lib/mogilefs/new_file/writer.rb
@@ -9,7 +9,7 @@ module MogileFS::NewFile::Writer
def puts(*args)
args.each do |obj|
write(obj)
- write("\n")
+ write("\n".freeze)
end
nil
end
--
EW
^ permalink raw reply related [relevance 7%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-12-29 7:42 5% [PATCH 0/3] misc cleanups Eric Wong
2016-12-29 7:42 7% ` [PATCH 2/3] use opt_str_freeze to avoid allocations in a few places Eric Wong
2017-01-31 18:38 5% [ANN] mogilefs-client 3.11.0 - MogileFS client library for Ruby Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/mogilefs-client.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).