Date | Commit message (Collapse) |
|
Fixes regression in #706. It intends to retain backward compatibility
with calls to #middleware by aliasing the method to the new
default_middleware_for_environment, but since it doesn't call #middleware
internally, subclasses that overrode it no longer work.
Restored compatibility by calling #middleware internally and delegating
its implementation to the new default_middleware_for_environment methods.
|
|
|
|
|
|
unknown keys
The current behaviour break rails server for any environment different
of development.
This behaviour was removed at 704be37e with a warning that if this
behavior is supported tests need to be added. The tests are already
there and they were not failing because "none" environment were added to
the hash. This environment is not a valid environment and it is on the
tests exactly to assert the behaviour that
default_middleware_by_environment always return an empty array for
unknown keys.
|
|
|
|
Had to put the class method definitions in an eigenclass wrapper
to use the 'alias' keyword sanely. It wouldn't be necessary if
old behavior of the middleware was unsupported, but that would be
too invasive for just a small clarity change.
|
|
A race condition can arise when two servers are started simultaneously. Both
instances may complete the check for an existing pidfile before either one
writes it.
Now the pidfile is opened with ::File::EXCL, which raises an error if the file
already exists. This error is handled by retrying the check and the write.
|
|
|
|
|
|
* Output reduced to a single line
* Integration test added that also suppresses and checks output
|
|
Then abort or remove the pidfile
|
|
Utilize this in the Rack::Server start test to avoid race condition on jruby
|
|
|
|
|
|
Signed-off-by: raggi <jftucker@gmail.com>
|