* [PATCH 1/3] linux_inet_diag: avoid unnecessary sockaddr initialization @ 2013-04-13 2:25 Eric Wong 2013-04-13 2:25 ` [PATCH 2/3] .gitignore: add .rbx Eric Wong 2013-04-13 2:25 ` [PATCH 3/3] switch back to gemspec development dependencies Eric Wong 0 siblings, 2 replies; 3+ messages in thread From: Eric Wong @ 2013-04-13 2:25 UTC (permalink / raw) To: raindrops This initialization was unnecessary and avoids the following warning with -Wmissing-braces on gcc 4.7.2-5 on Debian testing: linux_inet_diag.c: In function ‘stats_for’: linux_inet_diag.c:192:8: warning: missing braces around initializer [-Wmissing-braces] linux_inet_diag.c:192:8: warning: (near initialization for ‘sa.ss’) [-Wmissing-braces] --- ext/raindrops/linux_inet_diag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/raindrops/linux_inet_diag.c b/ext/raindrops/linux_inet_diag.c index 89206bf..d94dafd 100644 --- a/ext/raindrops/linux_inet_diag.c +++ b/ext/raindrops/linux_inet_diag.c @@ -189,7 +189,7 @@ static struct listen_stats *stats_for(st_table *table, struct inet_diag_msg *r) struct listen_stats *stats; size_t keylen; size_t portlen = sizeof("65535"); - union any_addr sa = { 0 }; + union any_addr sa; socklen_t len = sizeof(struct sockaddr_storage); int rc; int flags = NI_NUMERICHOST | NI_NUMERICSERV; -- 1.8.2.1.366.ge2af9e3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] .gitignore: add .rbx 2013-04-13 2:25 [PATCH 1/3] linux_inet_diag: avoid unnecessary sockaddr initialization Eric Wong @ 2013-04-13 2:25 ` Eric Wong 2013-04-13 2:25 ` [PATCH 3/3] switch back to gemspec development dependencies Eric Wong 1 sibling, 0 replies; 3+ messages in thread From: Eric Wong @ 2013-04-13 2:25 UTC (permalink / raw) To: raindrops Rubinius drops a .rbx directory on us nowadays --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 4c21977..52fa812 100644 --- a/.gitignore +++ b/.gitignore @@ -13,5 +13,6 @@ Makefile /doc /LATEST /tmp +/.rbx # http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ /Gemfile.lock -- 1.8.2.1.366.ge2af9e3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] switch back to gemspec development dependencies 2013-04-13 2:25 [PATCH 1/3] linux_inet_diag: avoid unnecessary sockaddr initialization Eric Wong 2013-04-13 2:25 ` [PATCH 2/3] .gitignore: add .rbx Eric Wong @ 2013-04-13 2:25 ` Eric Wong 1 sibling, 0 replies; 3+ messages in thread From: Eric Wong @ 2013-04-13 2:25 UTC (permalink / raw) To: raindrops This is more standardized than bundler for gem development. --- .gitignore | 2 -- Gemfile | 6 ------ raindrops.gemspec | 6 +++++- 3 files changed, 5 insertions(+), 9 deletions(-) delete mode 100644 Gemfile diff --git a/.gitignore b/.gitignore index 52fa812..0a82218 100644 --- a/.gitignore +++ b/.gitignore @@ -14,5 +14,3 @@ Makefile /LATEST /tmp /.rbx -# http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ -/Gemfile.lock diff --git a/Gemfile b/Gemfile deleted file mode 100644 index c9a1b64..0000000 --- a/Gemfile +++ /dev/null @@ -1,6 +0,0 @@ -source(ENV["GEM_SOURCE"] || :rubygems) -gem 'aggregate', '~> 0.2' -gem 'io-extra', '~> 1.2.3' -gem 'posix_mq', '~> 1.0' -gem 'rack', '~> 1.2' -gem 'unicorn', '>= 0.98' diff --git a/raindrops.gemspec b/raindrops.gemspec index dc44b75..ed8eaf5 100644 --- a/raindrops.gemspec +++ b/raindrops.gemspec @@ -22,7 +22,11 @@ Gem::Specification.new do |s| s.rdoc_options = rdoc_options s.rubyforge_project = %q{rainbows} s.test_files = test_files - s.add_development_dependency('bundler', '~> 1.0.10') + s.add_development_dependency('aggregate', '~> 0.2') + s.add_development_dependency('io-extra', [ '~> 1.2', '>= 1.2.3']) + s.add_development_dependency('posix_mq', '~> 2.0') + s.add_development_dependency('rack', '~> 1.2') + s.add_development_dependency('unicorn', '>= 0.98') # s.licenses = %w(LGPLv3) # accessor not compatible with older RubyGems end -- 1.8.2.1.366.ge2af9e3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-13 2:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-13 2:25 [PATCH 1/3] linux_inet_diag: avoid unnecessary sockaddr initialization Eric Wong 2013-04-13 2:25 ` [PATCH 2/3] .gitignore: add .rbx Eric Wong 2013-04-13 2:25 ` [PATCH 3/3] switch back to gemspec development dependencies Eric Wong
Code repositories for project(s) associated with this public inbox https://yhbt.net/raindrops.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).