Re: [PATCH] ...

[Brian Corrigan <brian@genexp.me>]

On Tue, Jun 5, 2012 at 8:49 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
>> Brian Corrigan <brian@genexp.me> wrote:
>> > Hey Eric - can you take it for here?  Also, thanks for the patience :).
>> > Fwiw, it's cool to have code in this project.  I learned a lot by reviewing
>> > the source.
>>
>> Sure thing.  Btw, don't top post and don't send HTML parts.  There's a
>> lot of technical mailing lists that don't welcome these things.
>>
>> Actually, did you get the test you added running at all?
>>
>> File.symlink returns 0 on success, so using the return value is bogus.
>> I'll rewrite it an squash a patch on top of it.
>
> I'll squash the following on top of your changes.
> However, I think the way unix_listener_stats behaves can pose
> some confusing usability problems with symlinks
>
> diff --git a/test/test_linux.rb b/test/test_linux.rb
> index 81463c9..1da86cf 100644
> --- a/test/test_linux.rb
> +++ b/test/test_linux.rb
> @@ -73,24 +73,24 @@ class TestLinux < Test::Unit::TestCase
>     us = UNIXServer.new(tmp.path)
>
>     # Create a symlink
> -    destination = Tempfile.new("somethingelse")
> -    destination.unlink # We need an available name, not an actual file
> -    link = File.symlink(tmp, destination)
> +    link = Tempfile.new("somethingelse")
> +    File.unlink(link.path) # We need an available name, not an actual file
> +    File.symlink(tmp.path, link.path)
>
>     @to_close << UNIXSocket.new(tmp.path)
>     stats = unix_listener_stats
> -    assert_equal 0, stats[link.path].active
> -    assert_equal 1, stats[link.path].queued
> +    assert_equal 0, stats[tmp.path].active
> +    assert_equal 1, stats[tmp.path].queued
>
> -    @to_close << UNIXSocket.new(tmp.path)
> +    @to_close << UNIXSocket.new(link.path)
>     stats = unix_listener_stats
> -    assert_equal 0, stats[link.path].active
> -    assert_equal 2, stats[link.path].queued
> +    assert_equal 0, stats[tmp.path].active
> +    assert_equal 2, stats[tmp.path].queued
>
>     @to_close << us.accept
>     stats = unix_listener_stats
> -    assert_equal 1, stats[link.path].active
> -    assert_equal 1, stats[link.path].queued
> +    assert_equal 1, stats[tmp.path].active
> +    assert_equal 1, stats[tmp.path].queued
>   end
>
>   def test_tcp
>
> --
> Eric Wong

Cheers Eric!

-- 
Brian