unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: [PATCH] set RACK_ENV on startup
Date: Tue, 3 Nov 2009 19:06:35 -0800	[thread overview]
Message-ID: <20091104030635.GA5282@dcvr.yhbt.net> (raw)
In-Reply-To: <C4216E7A-A91B-4712-93EF-0687668E9ABE@larsen.st>

Wayne Larsen <wayne@larsen.st> wrote:
> Most stupid patch ever, but is there a reason not to set RACK_ENV on  
> startup with `unicorn`, as RAILS_ENV is set with `unicorn_rails`?

Hi Wayne,

Does anything use/depend on it?  `unicorn' is modeled after `rackup' and
I don't think it's a good idea to expose things if nothing uses it
(rackup does not set it, either).

RAILS_ENV is an accepted standard for Rails applications and there are
plenty of things that already depend on it.

-- 
Eric Wong

  reply	other threads:[~2009-11-04  3:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  1:24 [PATCH] set RACK_ENV on startup Wayne Larsen
2009-11-04  3:06 ` Eric Wong [this message]
2009-11-04  3:51   ` Wayne Larsen
2009-11-04  5:29     ` Eric Wong
2009-11-04 17:13       ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104030635.GA5282@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).