unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Cc: ghazel@gmail.com
Subject: Re: Unicorn 0.97.0 old master is never dying
Date: Thu, 18 Mar 2010 01:40:22 -0700	[thread overview]
Message-ID: <20100318084022.GA11167@dcvr.yhbt.net> (raw)
In-Reply-To: <151643b21003170251g3cabd79bq36c9af668db574e0@mail.gmail.com>

ghazel@gmail.com wrote:
> I upgraded to Unicorn 0.97.0 from 0.96.1. Unicorn starts fine, but
> sending a USR2 to the 0.97.0 master launches a new master and all the
> workers, but never kills the old master. The new workers retry binding
> their admin TCP ports forever. Killing all the Unicorns and
> downgrading to returns peace to the forest.
> 
> Here are the before_fork and after_fork from my config/unicorn.rb:
> http://codepad.org/5LyVtyq7
> 
> Did something change with the Unicorn master in 0.97.0 that would
> require a change in my config, or is this a bug?
> 
> -Greg

Hi Greg,

Odd, are you passing the pid file path via the command-line?

I don't see the pid directive in the config file you posted there, so
there was nothing to check with File.exists?.  Are you using `unicorn'
or `unicorn_rails'?

There were some startup changes in 0.97.0, but I couldn't reproduce what
you're seeing with 'pid'.  That said, I'm not sure if that method of
killing old masters in the after_fork is very common.

-- 
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


  reply	other threads:[~2010-03-18  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17  9:51 Unicorn 0.97.0 old master is never dying ghazel
2010-03-18  8:40 ` Eric Wong [this message]
2010-03-18 16:35   ` ghazel
2010-03-19  8:23     ` Eric Wong
2010-03-19  8:55       ` ghazel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100318084022.GA11167@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=ghazel@gmail.com \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).