From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: Master repeatedly killing workers due to timeouts
Date: Sun, 11 Dec 2011 20:13:41 +0000 [thread overview]
Message-ID: <20111211201340.GA32406@dcvr.yhbt.net> (raw)
In-Reply-To: <4EE4BC04.60609@mrtech.ru>
Troex Nevelin <list@mrtech.ru> wrote:
> Hello,
>
> I have a simillar problem that started after update, 3 days ago we
> moved from REE 1.8 / Rails 2 to Ruby 1.9.3 and Rails 3.1, also we
> replaced memcached with redis so this is huge update and there are
> many places where we can have an issue.
>
> I also have checked my MySQL slow log and there are no requests which
> take more than 5 seconds to complete.
>
> My question is it possible to log the last request (URI) made to the
> worker before killing it on timeout?
There's no way to trap/handle SIGKILL in the worker, and telling the
master every URI the worker makes is too expensive.
This is horrible middleware, but _may_ work if you just forgot a timeout
and Ruby itself isn't blocked (due to a bad C extension):
class LogBeforeTimeout < Struct.new(:app)
def call(env)
thr = Thread.new do
sleep(59) # set this to Unicorn timeout - 1
unless Thread.current[:done]
path = env["PATH_INFO"]
qs = env["QUERY_STRING"] and path = "#{path}?#{qs}"
env["rack.logger"].warn("#{path} about to die from SIGKILL")
end
end
app.call(env)
ensure
thr[:done] = true
thr.run
end
end
Or you can just log the nev before app.call:
def call(env)
path = env["PATH_INFO"]
qs = env["QUERY_STRING"] and path = "#{path}?#{qs}"
env["rack.logger"].debug "START #{path}"
app.call(env)
ensure
env["rack.logger"].debug "FINISH #{path}"
end
And look for START lines without corresponding FINISH lines.
All code in this post is totally untested, so may contain syntax errors
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
next prev parent reply other threads:[~2011-12-11 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 18:19 Master repeatedly killing workers due to timeouts Jonathan del Strother
2011-12-08 20:23 ` Eric Wong
2011-12-08 22:24 ` Jonathan del Strother
2011-12-11 14:19 ` Troex Nevelin
2011-12-11 20:13 ` Eric Wong [this message]
2011-12-15 20:29 ` Troex Nevelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111211201340.GA32406@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).