Re: [PATCH] Start the server if another user has a PID matching our stale pidfile.

[Eric Wong <normalperson@yhbt.net>]

Eric Wong <normalperson@yhbt.net> wrote:
> Graham Bleach <graham@darkskills.org.uk> wrote:
> > If unicorn doesn't get terminated cleanly (for example if the machine
> > has its power interrupted) and the pid in the pidfile gets used by
> > another process, the current unicorn code will exit and not start a
> > server. This tiny patch fixes that behaviour.
> 
> Thanks!  Acked-by: Eric Wong <normalperson@yhbt.net>
> 
> and pushed to master on git://bogomips.org/unicorn.git

Btw, I also pushed this to be a little more informative:

>From d0e7d8d770275654024887a05d9e986589ba358c Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Tue, 20 Mar 2012 20:05:59 +0000
Subject: [PATCH] log EPERM errors from invalid pid files

In some cases, EPERM may indicate a real configuration problem,
but it can also just mean the pid file is stale.
---
 lib/unicorn/http_server.rb |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index 0c2af5d..ede6264 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -656,7 +656,10 @@ class Unicorn::HttpServer
     wpid <= 0 and return
     Process.kill(0, wpid)
     wpid
-    rescue Errno::ESRCH, Errno::ENOENT, Errno::EPERM
+    rescue Errno::EPERM
+      logger.info "pid=#{path} possibly stale, got EPERM signalling PID:#{wpid}"
+      nil
+    rescue Errno::ESRCH, Errno::ENOENT
       # don't unlink stale pid files, racy without non-portable locking...
   end
 
-- 
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying