From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Cc: "Benedikt Böhm" <bb@xnull.de>
Subject: Re: [PATCH] make stderr_path/stdout_path support IO objects directly
Date: Thu, 22 Mar 2012 08:00:37 +0000 [thread overview]
Message-ID: <20120322080037.GA11064@dcvr.yhbt.net> (raw)
In-Reply-To: <1332400449-25478-1-git-send-email-bb@xnull.de>
Benedikt Böhm <bb@xnull.de> wrote:
Hello, can you explain in the commit message why this functionality is
useful to have?
SIGUSR1 log file reopening only works because it relies on knowing
File#path on File objects
> ---
> lib/unicorn/configurator.rb | 2 +-
> lib/unicorn/http_server.rb | 6 +++++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
Test cases for new functionality would be nice, too.
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2012-03-22 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 7:14 [PATCH] make stderr_path/stdout_path support IO objects directly Benedikt Böhm
2012-03-22 8:00 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322080037.GA11064@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=bb@xnull.de \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).