* [PATCH] http_request: drop unnecessary #clear call
@ 2021-03-13 2:31 14% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2021-03-13 2:31 UTC (permalink / raw)
To: Dirkjan Bussink; +Cc: John Crepezzi, Kevin Sawicki, unicorn-public
Also noticed #clear is unnecessary, now
------------8<-----------
Subject: [PATCH] http_request: drop unnecessary #clear call
Since we allocate a new request object for each request,
the #clear call is now unnecessary
---
lib/unicorn/http_request.rb | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/unicorn/http_request.rb b/lib/unicorn/http_request.rb
index 6ca4592..e3ad592 100644
--- a/lib/unicorn/http_request.rb
+++ b/lib/unicorn/http_request.rb
@@ -62,7 +62,6 @@ def self.check_client_connection=(bool)
# This does minimal exception trapping and it is up to the caller
# to handle any socket errors (e.g. user aborted upload).
def read(socket)
- clear
e = env
# From https://www.ietf.org/rfc/rfc3875:
^ permalink raw reply related [relevance 14%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
[not found] <F6712BF3-A4DD-41EE-8252-B9799B35E618@github.com>
[not found] ` <20210311030250.GA1266@dcvr>
[not found] ` <7F6FD017-7802-4871-88A3-1E03D26D967C@github.com>
2021-03-12 9:41 ` Potential Unicorn vulnerability Eric Wong
2021-03-12 11:14 ` Dirkjan Bussink
2021-03-12 12:00 ` Eric Wong
2021-03-12 12:24 ` Dirkjan Bussink
2021-03-13 2:26 ` Eric Wong
2021-03-13 2:31 14% ` [PATCH] http_request: drop unnecessary #clear call Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).