From: Jeremy Evans <jeremyevans0@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Fix hang when running tests on OpenBSD by skipping two tests
Date: Mon, 14 Nov 2011 20:33:06 +0100 [thread overview]
Message-ID: <CADGZSSf-Ggg8K0N6Y2NUuUsXxK7eLpd4KQ6CEg=eHE_nVZatXg@mail.gmail.com> (raw)
This skips two tests on OpenBSD when cause hangs when running the tests.
This is obviously not a permanent fix, but I'm not sure why the tests
are hanging, and hanging during a test is bad. I suppose you could
also use a timeout, so the test fails instead of hangs. I'll be happy
to test other patches to either the test suite or the library code
(assuming the hang is fixable on OpenBSD).
After this patch, the test suite passes fine on OpenBSD.
Jeremy
--- test/exec/test_exec.rb.orig Mon Nov 14 18:38:09 2011
+++ test/exec/test_exec.rb Mon Nov 14 18:38:37 2011
@@ -968,7 +968,7 @@ EOF
assert_nothing_raised { Process.kill(:QUIT, daemon_pid) }
wait_for_death(daemon_pid)
end
- end
+ end unless RUBY_PLATFORM =~ /openbsd/i
def test_default_listen_upgrade_holds_listener
default_listen_lock do
@@ -998,7 +998,7 @@ EOF
assert_nothing_raised { Process.kill(:QUIT, daemon_pid) }
wait_for_death(daemon_pid)
end
- end
+ end unless RUBY_PLATFORM =~ /openbsd/i
def default_listen_setup
File.open("config.ru", "wb") { |fp| fp.syswrite(HI.gsub("HI", '#$$')) }
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
next reply other threads:[~2011-11-14 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 19:33 Jeremy Evans [this message]
2011-11-14 20:54 ` Fix hang when running tests on OpenBSD by skipping two tests Eric Wong
2011-11-14 23:46 ` Jeremy Evans
2011-11-15 3:17 ` Eric Wong
2011-11-15 20:03 ` Jeremy Evans
2011-11-15 21:19 ` Jeremy Evans
2011-11-15 22:36 ` Eric Wong
2011-11-16 1:18 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADGZSSf-Ggg8K0N6Y2NUuUsXxK7eLpd4KQ6CEg=eHE_nVZatXg@mail.gmail.com' \
--to=jeremyevans0@gmail.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).