unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / Atom feed
From: Dylan Thacker-Smith <dylan.smith@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@bogomips.org
Subject: Re: [PATCH] Check for Socket::TCP_INFO constant before trying to get TCP_INFO
Date: Sat, 25 Mar 2017 22:52:21 -0400
Message-ID: <CAK9CFuh3Pf55ng+VmvFeveeG8BSCzKncPcJjkZTCyEaYRx4qng@mail.gmail.com> (raw)
In-Reply-To: <20170326024112.GA28554@starla>

On Sat, Mar 25, 2017 at 10:41 PM, Eric Wong <e@80x24.org> wrote:
> Is the last line to set "@@tcpi_inspect_ok = true" still
> necessary?  It was necessary in Jeremy's version, but I think
> you can safely omit it, now.

No it isn't needed, so you can remove it.

I had just started my patch before seeing his, so reverted his as part
of rebasing and this line was present before his patch.

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-26  1:49 Dylan Thacker-Smith
2017-03-26  2:41 ` Eric Wong
2017-03-26  2:52   ` Dylan Thacker-Smith [this message]
2017-03-26  3:37     ` Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK9CFuh3Pf55ng+VmvFeveeG8BSCzKncPcJjkZTCyEaYRx4qng@mail.gmail.com \
    --to=dylan.smith@shopify.com \
    --cc=e@80x24.org \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://yhbt.net/unicorn-public
	git clone --mirror http://ou63pmih66umazou.onion/unicorn-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git