unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: "Robinson Jr, James P (Jim)      HHHH" <James.Robinson3@Cigna.com>
To: "unicorn-public@bogomips.org" <unicorn-public@bogomips.org>
Subject: using pp without require 'pp' when $DEBUG = True
Date: Thu, 16 Nov 2017 00:57:41 +0000	[thread overview]
Message-ID: <D6324CB4.7BC3E%james.robinson3@cigna.com> (raw)

 	I am not usually a ruby developer, and I just recently stumbled across
an odd bug, that only someone who  didn¹t know what they were doing would
stumble across.  I am honestly not sure if this really counts as a bug,
but I thought I should let you know.

unicorn/lib/unicorn.rb line 62 is:

      pp({ :inner_app => inner_app }) if $DEBUG

Nowhere in the file is there require Œpp¹

This is not an issue if you run "unicorn -d config.ru², but If you
manually set $DEBUG = true,  which I foolishly did because I didn¹t
realize that $DEBUG was a special variable in ruby,  you get an undefined
method error.   

I will be changing my code to use a different variable name, however I am
not sure if there are valid reasons to manually set $DEBUG in ruby.  If
there are, this may be an issue for others.

I think the simplest solution would be to replace the line above with an
if block:

      if $DEBUG
        require 'pp'
        pp({ :inner_app => inner_app })

Similar blocks appear in unicorn/bin/unicorn and
unicorn/bin/unicorn_rails. I am assuming the one in unicorn/bin/unicorn
is the one that allows it to work when using the -d flag. If there really
is never any reason to manually set $DEBUG I¹m sorry I wasted your time.

In any case, thank you for Unicorn!

Jim Robinson

CONFIDENTIALITY NOTICE: If you have received this email in error,
please immediately notify the sender by e-mail at the address shown. 
This email transmission may contain confidential information.  This
information is intended only for the use of the individual(s) or entity to
whom it is intended even if addressed incorrectly.  Please delete it from
your files if you are not the intended recipient.  Thank you for your
compliance.  Copyright (c) 2017 Cigna

             reply	other threads:[~2017-11-16  0:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  0:57 Robinson Jr, James P (Jim)      HHHH [this message]
2017-11-16  1:30 ` using pp without require 'pp' when $DEBUG = True Eric Wong
2017-11-16 21:09   ` [PATCH] require 'pp' if $DEBUG is set by Rack app Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6324CB4.7BC3E%james.robinson3@cigna.com \
    --to=james.robinson3@cigna.com \
    --cc=unicorn-public@bogomips.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).