unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Lee Bankewitz <leebankewitz@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: Log line formatting
Date: Fri, 6 Nov 2009 17:09:30 -0500	[thread overview]
Message-ID: <b32c81260911061409s1e02249exd12aa711d53d66d2@mail.gmail.com> (raw)
In-Reply-To: <20091106214005.GA17969@dcvr.yhbt.net>

On Fri, Nov 6, 2009 at 4:40 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Lee Bankewitz <leebankewitz@gmail.com> wrote:
>> Howdy.
>>
>> I'm running Unicorn 0.94 in production (its working wonderfully).  One
>> question about the log line formats in the unicorn log.
>>
>> In my unicorn config file, I have:
>> logger Logger.new("log/unicorn.log")
>>
>> I see timestamps on the the initial log lines when unicorn first starts, i.e.:
>> "I, [2009-11-06T12:25:13.812367 #2437]  INFO -- : listening on
>> addr=0.0.0.0:3000 fd=5"
>>
>> But the format of the log line changes soon thereafter:
>> "master process ready"
>> "worker=0 ready"
>>
>> any ideas why this is happening? I'd prefer to have the initial format
>> for every line.
>
> Hi Lee,
>
> This with Rails?  Unfortunately, Rails seems to monkey patch the core
> Logger format methods.  If you find a clean solution to this without
> bad side effects, please let the rest of us know, thanks.
>
> --
> Eric Wong
> _______________________________________________
> mongrel-unicorn mailing list
> mongrel-unicorn@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-unicorn
>

Thanks Eric,

Rails does indeed override the default formatting of Logger.  I got
around it for now by setting the formatter explicitly to the ruby
default formatter, as follows:

# config/unicorn.rb
unicorn_logger = Logger.new("unicorn.log")
unicorn_logger.formatter = Logger::Formatter.new
logger unicorn_logger

I think its bad behavior by rails though, so I'll see if there's any
interest in a Rails patch to address this.

-lee

  reply	other threads:[~2009-11-06 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06 21:19 Log line formatting Lee Bankewitz
2009-11-06 21:40 ` Eric Wong
2009-11-06 22:09   ` Lee Bankewitz [this message]
2009-11-06 22:56     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32c81260911061409s1e02249exd12aa711d53d66d2@mail.gmail.com \
    --to=leebankewitz@gmail.com \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).