diff options
author | Eric Wong <normalperson@yhbt.net> | 2010-02-12 23:59:55 -0800 |
---|---|---|
committer | Eric Wong <normalperson@yhbt.net> | 2010-02-13 00:31:52 -0800 |
commit | b30ae5c5f01c36f39b9c301e59d8ad9fb24f7c1b (patch) | |
tree | 221140413a957ecce9cb34040320c6aa0a8bed6b /ext | |
parent | 47c50ed7ebb2a97c2d289eede169f3e2e3f5e89b (diff) | |
download | unicorn-b30ae5c5f01c36f39b9c301e59d8ad9fb24f7c1b.tar.gz |
First off, this memory leak DOES NOT affect Unicorn itself. Unicorn allocates the HttpParser once and always reuses it in every sequential request. This leak affects applications which repeatedly allocate a new HTTP parser. Thus this bug affects _all_ deployments of Rainbows! and Zbatery. These servers allocate a new parser for every client connection. I misread the Data_Make_Struct/Data_Wrap_Struct documentation and ended up passing NULL as the "free" argument instead of -1, causing the memory to never be freed. From README.EXT in the MRI source which I misread: > The free argument is the function to free the pointer > allocation. If this is -1, the pointer will be just freed. > The functions mark and free will be called from garbage > collector.
Diffstat (limited to 'ext')
-rw-r--r-- | ext/unicorn_http/unicorn_http.rl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/unicorn_http/unicorn_http.rl b/ext/unicorn_http/unicorn_http.rl index 6232e2c..a95224c 100644 --- a/ext/unicorn_http/unicorn_http.rl +++ b/ext/unicorn_http/unicorn_http.rl @@ -439,7 +439,7 @@ static void hp_mark(void *ptr) static VALUE HttpParser_alloc(VALUE klass) { struct http_parser *hp; - return Data_Make_Struct(klass, struct http_parser, hp_mark, NULL, hp); + return Data_Make_Struct(klass, struct http_parser, hp_mark, -1, hp); } |