diff options
author | Eric Wong <e@80x24.org> | 2015-10-27 03:33:12 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2015-10-27 05:00:57 +0000 |
commit | 1f88b6e723fff2302c13f95177cc7253da8b57d6 (patch) | |
tree | ffc63160f1e74862389368f3767c4bb0fb2fc5a1 /lib/unicorn/http_server.rb | |
parent | a47c5c4c9091cb93bbe6495be6429ef9d656d72b (diff) | |
download | unicorn-1f88b6e723fff2302c13f95177cc7253da8b57d6.tar.gz |
For some reason, I thought invalid descriptors passed to UNICORN_FD would be automatically closed by the master process; but apparently this hasn't been the case. On the other hand, this bug has been around for over 6 years now and nobody noticed or cared enough to tell us, so fixing it might break existing setups. Since there may be users relying on this behavior, we cannot change the behavior anymore; so update the documentation and write at test to ensure we can never "fix" this bug at the expense of breaking any working setups which may be out there. Keep in mind that a before_exec hook may always be used to modify the UNICORN_FD environment by setting the close_on_exec flag and removing the appropriate descriptor from the environment. I originally intended to add the ability to inherit new listeners without a config file specification so systemd users can avoid repeating themselves in the systemd and unicorn config files, but apparently there is nothing to change in our code.
Diffstat (limited to 'lib/unicorn/http_server.rb')
0 files changed, 0 insertions, 0 deletions