diff options
author | Eric Wong <normalperson@yhbt.net> | 2012-11-13 20:22:13 +0000 |
---|---|---|
committer | Eric Wong <normalperson@yhbt.net> | 2012-11-13 20:22:13 +0000 |
commit | f4af812a28b03508c96853739aea53f7a6714abf (patch) | |
tree | cbfe8ae9ae2a6c228f0176f93ff811030aade122 /test/unit/test_upload.rb | |
parent | 4bd0dbdf2d27672dc941746e06b647ea26fe63ee (diff) | |
download | unicorn-f4af812a28b03508c96853739aea53f7a6714abf.tar.gz |
assert_nothing_raised ends up hiding errors and backtraces, making things harder to debug. Since Test::Unit already fails on uncaught exceptions, there is no need to assert on the lack of exceptions for a successful test run. This is a followup to commit 5acf5522295c947d3118926d1a1077007f615de9
Diffstat (limited to 'test/unit/test_upload.rb')
-rw-r--r-- | test/unit/test_upload.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/unit/test_upload.rb b/test/unit/test_upload.rb index 7777e00..bcce4bc 100644 --- a/test/unit/test_upload.rb +++ b/test/unit/test_upload.rb @@ -163,7 +163,7 @@ class UploadTest < Test::Unit::TestCase assert_raise(Errno::ECONNRESET, Errno::EPIPE) do ::Unicorn::Const::CHUNK_SIZE.times { sock.syswrite(buf) } end - assert_nothing_raised { sock.gets } + sock.gets tmp.rewind assert_equal length, tmp.read.to_i end |