yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] test/test_server: fix leftover process from inherit test
Date: Mon,  9 Mar 2015 10:04:22 +0000	[thread overview]
Message-ID: <1425895462-22981-1-git-send-email-e@80x24.org> (raw)

Oops, this test bug was introduced in:
commit e413325737f23c5ec27a02246f95077bc1fb038d
("acceptor: close inherited-but-unneeded sockets")
---
 test/test_server.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/test_server.rb b/test/test_server.rb
index b7cb3e6..0410f65 100644
--- a/test/test_server.rb
+++ b/test/test_server.rb
@@ -815,7 +815,7 @@ class TestServer < Testcase
       GTL.synchronize { app(:rack, ru) { listen "#{host}:#{port}" } }
       logger(Logger.new(err.path))
     end
-    mkserver(cfg, @srv) do
+    pid = mkserver(cfg, @srv) do
       s2.autoclose = false
       ENV["YAHNS_FD"] = "#{@srv.fileno},#{s2.fileno}"
     end
@@ -842,5 +842,7 @@ class TestServer < Testcase
     assert_nil a2.read(1)
     a2.close
     s2.close
+  ensure
+    quit_wait(pid)
   end
 end
-- 
2.3.1.170.ge0b4cad


                 reply	other threads:[~2015-03-09 10:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425895462-22981-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).