yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] proxy_pass: quiet down ECONNRESET and EPIPE, too
Date: Sat,  3 Oct 2015 11:36:45 +0000	[thread overview]
Message-ID: <20151003113645.12309-1-e@80x24.org> (raw)

Clients may disconnect on us while we're writing the response
here, so we should shut the backtrace up to avoid polluting
logs.
---
 lib/yahns/proxy_pass.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index 89c6ef8..9512318 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -74,7 +74,10 @@ class Yahns::ProxyPass # :nodoc:
     rescue => e
       # avoid polluting logs with a giant backtrace when the problem isn't
       # fixable in code.
-      e.set_backtrace([]) if Errno::ECONNREFUSED === e
+      case e
+      when Errno::ECONNREFUSED, Errno::ECONNRESET, Errno::EPIPE
+        e.set_backtrace([])
+      end
       c.proxy_err_response(502, self, e, nil)
     end
 
-- 
EW


                 reply	other threads:[~2015-10-03 11:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151003113645.12309-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).