From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: corking headers on Transfer-Encoding:chunked
Date: Fri, 29 Apr 2016 07:35:08 +0000 [thread overview]
Message-ID: <20160429073508.GA30698@dcvr.yhbt.net> (raw)
I don't think I can safely apply the following patch,
at least I don't think we can do it by default.
I wish I could, given how I always use Rack::Deflater:
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -152,6 +152,9 @@ def http_response_write(status, headers, body)
when %r{\AContent-Length\z}i
flags |= MSG_MORE if have_more?(value)
kv_str(buf, key, value)
+ when %r{\ATransfer-Encoding\z}i && value =~ /\bchunked\b/i
+ flags |= MSG_MORE
+ kv_str(buf, key, value)
when "rack.hijack"
hijack = value
else
Problem is, we never know how long it'll take an app to
generate the first part of the response body in:
body.each { |chunk| ... }
And it is likely somebody might want to send a header out
ASAP, making the 200ms MSG_MORE delay unnacceptable; right?
reply other threads:[~2016-04-29 7:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429073508.GA30698@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).