yahns Ruby server user/dev discussion
 help / color / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: corking headers on Transfer-Encoding:chunked
Date: Fri, 29 Apr 2016 07:35:08 +0000
Message-ID: <20160429073508.GA30698@dcvr.yhbt.net> (raw)

I don't think I can safely apply the following patch,
at least I don't think we can do it by default.
I wish I could, given how I always use Rack::Deflater:

--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -152,6 +152,9 @@ def http_response_write(status, headers, body)
         when %r{\AContent-Length\z}i
           flags |= MSG_MORE if have_more?(value)
           kv_str(buf, key, value)
+        when %r{\ATransfer-Encoding\z}i && value =~ /\bchunked\b/i
+          flags |= MSG_MORE
+          kv_str(buf, key, value)
         when "rack.hijack"
           hijack = value
         else

Problem is, we never know how long it'll take an app to
generate the first part of the response body in:

	body.each { |chunk| ... }

And it is likely somebody might want to send a header out
ASAP, making the 200ms MSG_MORE delay unnacceptable; right?

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160429073508.GA30698@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

yahns Ruby server user/dev discussion

Archives are clonable:
	git clone --mirror https://yhbt.net/yahns-public
	git clone --mirror http://ou63pmih66umazou.onion/yahns-public

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.yahns

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git