yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] openssl_client: avoid undefined SSL_write behavior
Date: Sat, 6 Aug 2016 10:45:53 +0000	[thread overview]
Message-ID: <20160806104553.GA28283@starla> (raw)

Sometimes apps may trigger zero-byte chunks in the response
body for whatever reason.  We should maintain consistent
behavior with the rest of kgio; and Ruby OpenSSL::SSL::SSLSocket
should maintain consistent behavior with the core IO class:

	https://bugs.ruby-lang.org/issues/12660
---
 *sigh*  The pain of being an early adopter; it feels like
 nobody deployed non-blocking servers using Ruby OpenSSL
 to production before me :x

 c.f. https://bugs.ruby-lang.org/issues/12126

 lib/yahns/openssl_client.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/yahns/openssl_client.rb b/lib/yahns/openssl_client.rb
index 439bc75..0d376bd 100644
--- a/lib/yahns/openssl_client.rb
+++ b/lib/yahns/openssl_client.rb
@@ -38,12 +38,14 @@ def yahns_init_ssl(ssl_ctx)
   end
 
   def kgio_trywrite(buf)
+    len = buf.bytesize
+    return if len == 0
     buf = @ssl_blocked = buf.dup
     case rv = @ssl.write_nonblock(buf, exception: false)
     when :wait_readable, :wait_writable
       return rv # do not clear ssl_blocked
     when Integer
-      rv = buf.bytesize == rv ? nil : buf.byteslice(rv, buf.bytesize - rv)
+      rv = len == rv ? nil : buf.byteslice(rv, len - rv)
     end
     @ssl_blocked = nil
     rv
-- 
EW

                 reply	other threads:[~2016-08-06 10:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160806104553.GA28283@starla \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    --subject='Re: [PATCH] openssl_client: avoid undefined SSL_write behavior' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).