yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] extras/exec_cgi: remove unecessary .freeze calls
Date: Fri, 28 Dec 2018 19:43:40 +0000	[thread overview]
Message-ID: <20181228194340.31914-1-e@80x24.org> (raw)

Operations via Array#map are NOT optimized away by opt_str_lit
in the VM, and they're unnecessary anyways with the
"frozen_string_literal: true" comment in Ruby 2.3+.
---
 extras/exec_cgi.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/exec_cgi.rb b/extras/exec_cgi.rb
index 2746c09..8a1939d 100644
--- a/extras/exec_cgi.rb
+++ b/extras/exec_cgi.rb
@@ -82,7 +82,7 @@ def close
     SERVER_PROTOCOL
     SERVER_SOFTWARE
     SCRIPT_NAME
-  ).map(&:freeze)  # frozen strings are faster for Hash assignments
+  )
 
   def initialize(*args)
     @env = Hash === args[0] ? args.shift : {}
-- 
EW


                 reply	other threads:[~2018-12-28 19:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181228194340.31914-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).