From: Bo Gan <ganboing@gmail.com>
To: E Shattow <lucent@gmail.com>, Hal Feng <hal.feng@starfivetech.com>
Cc: Bo Gan <ganboing@gmail.com>,
"rick@andestech.com" <rick@andestech.com>,
"ycliang@andestech.com" <ycliang@andestech.com>,
"trini@konsulko.com" <trini@konsulko.com>,
"yanhong.wang@starfivetech.com" <yanhong.wang@starfivetech.com>,
Minda Chen <minda.chen@starfivetech.com>,
"duwe@suse.de" <duwe@suse.de>,
"namcao@linutronix.de" <namcao@linutronix.de>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Mason Huo <mason.huo@starfivetech.com>,
"chanho61.park@samsung.com" <chanho61.park@samsung.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [PATCH] riscv: dts: jh7110: Enable PLL node in SPL
Date: Tue, 9 Apr 2024 23:44:23 -0700 [thread overview]
Message-ID: <0eda64cb-4ca8-f8bc-7515-6d2a2d3d4638@gmail.com> (raw)
In-Reply-To: <CANV2PTMPrQVZhWvNFxi8-RA0ZC4UAF1sHBbHiipUc01aWx6oqg@mail.gmail.com>
On 4/9/24 6:55 PM, E Shattow wrote:
> Original speed class SD cards fail with this change "unable to change mode".
>
> On Tue, Mar 12, 2024 at 4:12 AM Hal Feng <hal.feng@starfivetech.com> wrote:
>>
>>> On 06.03.24 11:00, Bo Gan wrote:
>>>
>>> Previously PLL node was missing from SPL dts. This caused BUS_ROOT to stay on
>>> OSC clock (24Mhz). As a result, all peripherals have to run at a much lower
>>> frequency, and loading from sdcard/emmc is slow.
>>> Thus, enabling PLL node in dts to fix this.
>>>
>>> Signed-off-by: Bo Gan <ganboing@gmail.com>
>>
>> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
>>
The BUS_ROOT clock will have to be switched to PLL2 anyway in U-Boot proper or
in Linux, because it's the parent or grandparent clock for *lots* of devices,
including PCIe, i2c, spi, qspi... If there's an issue with this change, then
I suspect there's something wrong with the dw_mmc driver.
Bo
next prev parent reply other threads:[~2024-04-10 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 3:00 [PATCH] riscv: dts: jh7110: Enable PLL node in SPL Bo Gan
2024-03-12 5:12 ` Leo Liang
2024-03-12 6:09 ` Hal Feng
2024-04-10 1:55 ` E Shattow
2024-04-10 6:44 ` Bo Gan [this message]
2024-04-17 4:59 ` E Shattow
2024-04-20 0:51 ` Bo Gan
2024-04-20 10:56 ` E Shattow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eda64cb-4ca8-f8bc-7515-6d2a2d3d4638@gmail.com \
--to=ganboing@gmail.com \
--cc=chanho61.park@samsung.com \
--cc=duwe@suse.de \
--cc=hal.feng@starfivetech.com \
--cc=lucent@gmail.com \
--cc=mason.huo@starfivetech.com \
--cc=minda.chen@starfivetech.com \
--cc=namcao@linutronix.de \
--cc=rick@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xingyu.wu@starfivetech.com \
--cc=yanhong.wang@starfivetech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.