From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: <luiz.dentz@gmail.com>, <luiz.von.dentz@intel.com>,
<marcel@holtmann.org>
Cc: <linux-bluetooth@vger.kernel.org>,
<bartosz.golaszewski@linaro.org>,
<krzysztof.kozlowski@linaro.org>, <wt@penguintechs.org>
Subject: Re: [PATCH v2 1/2] Bluetooth: MGMT: Fix failing to MGMT_OP_ADD_UUID/MGMT_OP_REMOVE_UUID
Date: Sat, 20 Apr 2024 06:05:12 +0800 [thread overview]
Message-ID: <1bac8595-4ca4-43f9-ab20-e0dd55d93d8b@quicinc.com> (raw)
In-Reply-To: <1713563327-19694-2-git-send-email-quic_zijuhu@quicinc.com>
On 4/20/2024 5:48 AM, Zijun Hu wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> These commands don't require the adapter to be up and running so don't
> use hci_cmd_sync_queue which would check that flag, instead use
> hci_cmd_sync_submit which would ensure mgmt_class_complete is set
> properly regardless if any command was actually run or not.
>
> Link: https://github.com/bluez/bluez/issues/809
> Fixes: d883a4669a1d ("Bluetooth: hci_sync: Only allow hci_cmd_sync_queue if running")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/mgmt.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 7129e70a0253..68deec968405 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -2623,7 +2623,11 @@ static int add_uuid(struct sock *sk, struct hci_dev *hdev, void *data, u16 len)
> goto failed;
> }
>
> - err = hci_cmd_sync_queue(hdev, add_uuid_sync, cmd, mgmt_class_complete);
> + /* MGMT_OP_ADD_UUID don't require adapter the UP/Running so use
> + * hci_cmd_sync_submit instead of hci_cmd_sync_queue.
> + */
> + err = hci_cmd_sync_submit(hdev, add_uuid_sync, cmd,
> + mgmt_class_complete);
> if (err < 0) {
> mgmt_pending_free(cmd);
> goto failed;
> @@ -2717,8 +2721,11 @@ static int remove_uuid(struct sock *sk, struct hci_dev *hdev, void *data,
> goto unlock;
> }
>
> - err = hci_cmd_sync_queue(hdev, remove_uuid_sync, cmd,
> - mgmt_class_complete);
> + /* MGMT_OP_REMOVE_UUID don't require adapter the UP/Running so use
> + * hci_cmd_sync_submit instead of hci_cmd_sync_queue.
> + */
> + err = hci_cmd_sync_submit(hdev, remove_uuid_sync, cmd,
> + mgmt_class_complete);
> if (err < 0)
> mgmt_pending_free(cmd);
>
> @@ -2784,8 +2791,11 @@ static int set_dev_class(struct sock *sk, struct hci_dev *hdev, void *data,
> goto unlock;
> }
>
> - err = hci_cmd_sync_queue(hdev, set_class_sync, cmd,
> - mgmt_class_complete);
> + /* MGMT_OP_SET_DEV_CLASS don't require adapter the UP/Running so use
> + * hci_cmd_sync_submit instead of hci_cmd_sync_queue.
> + */
> + err = hci_cmd_sync_submit(hdev, set_class_sync, cmd,
> + mgmt_class_complete);
> if (err < 0)
> mgmt_pending_free(cmd);
>
sorry to send wrong patch sets please ignore it.
next prev parent reply other threads:[~2024-04-19 22:05 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:06 [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-18 14:06 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Zijun Hu
2024-04-18 14:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-18 16:52 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Krzysztof Kozlowski
2024-04-18 21:16 ` quic_zijuhu
2024-04-18 22:37 ` Krzysztof Kozlowski
2024-04-18 23:17 ` quic_zijuhu
2024-04-19 13:49 ` Krzysztof Kozlowski
2024-04-20 5:25 ` quic_zijuhu
2024-04-20 5:27 ` quic_zijuhu
2024-04-20 11:13 ` Krzysztof Kozlowski
2024-04-20 23:01 ` quic_zijuhu
2024-04-18 17:00 ` Bartosz Golaszewski
2024-04-18 21:43 ` quic_zijuhu
2024-04-18 22:42 ` Bartosz Golaszewski
2024-04-18 23:36 ` quic_zijuhu
2024-04-19 21:27 ` Bartosz Golaszewski
2024-04-20 5:39 ` quic_zijuhu
2024-04-21 7:14 ` Wren Turkal
2024-04-21 9:40 ` quic_zijuhu
2024-04-22 5:26 ` Wren Turkal
2024-04-18 14:06 ` [PATCH v1 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-18 16:48 ` Krzysztof Kozlowski
2024-04-18 20:34 ` quic_zijuhu
2024-04-18 20:58 ` Krzysztof Kozlowski
2024-04-18 22:05 ` quic_zijuhu
2024-04-18 22:38 ` Krzysztof Kozlowski
2024-04-18 23:24 ` quic_zijuhu
2024-04-19 21:48 ` [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 21:48 ` [PATCH v2 1/2] Bluetooth: MGMT: Fix failing to MGMT_OP_ADD_UUID/MGMT_OP_REMOVE_UUID Zijun Hu
2024-04-19 22:05 ` quic_zijuhu [this message]
2024-04-19 22:12 ` [v2,1/2] " bluez.test.bot
2024-04-19 21:48 ` [PATCH v2 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:06 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 22:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:30 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 11:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Krzysztof Kozlowski
2024-04-20 21:28 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-20 11:07 ` Krzysztof Kozlowski
2024-04-20 21:42 ` quic_zijuhu
2024-04-20 11:01 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Krzysztof Kozlowski
2024-04-22 7:44 ` Krzysztof Kozlowski
2024-04-22 8:07 ` quic_zijuhu
2024-04-22 8:11 ` Krzysztof Kozlowski
2024-04-22 8:21 ` quic_zijuhu
2024-04-20 22:06 ` [PATCH v4 " Zijun Hu
2024-04-20 22:06 ` [PATCH v4 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-20 22:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 22:06 ` [PATCH v4 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-21 7:44 ` [PATCH v4 0/2] Fix two regression issues for QCA controllers Wren Turkal
2024-04-21 9:30 ` quic_zijuhu
2024-04-21 18:41 ` Krzysztof Kozlowski
2024-04-22 0:14 ` quic_zijuhu
2024-04-22 5:21 ` Wren Turkal
2024-04-22 8:51 ` Bartosz Golaszewski
2024-04-22 10:42 ` Wren Turkal
2024-04-22 13:02 ` Bartosz Golaszewski
2024-04-24 1:52 ` Wren Turkal
2024-04-22 5:52 ` Krzysztof Kozlowski
2024-04-22 6:00 ` quic_zijuhu
2024-04-22 7:45 ` Krzysztof Kozlowski
2024-04-22 10:05 ` quic_zijuhu
2024-04-22 12:28 ` Krzysztof Kozlowski
2024-04-21 13:51 ` Krzysztof Kozlowski
2024-04-22 7:38 ` [PATCH v5 " Zijun Hu
2024-04-22 7:38 ` [PATCH v5 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-22 8:36 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-22 7:38 ` [PATCH v5 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-22 7:42 ` Krzysztof Kozlowski
2024-04-22 11:25 ` quic_zijuhu
2024-04-22 12:22 ` Krzysztof Kozlowski
2024-04-22 12:59 ` quic_zijuhu
2024-04-25 0:59 ` [PATCH v6 v7] Fix two BT regression issues for QCA6390 Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bac8595-4ca4-43f9-ab20-e0dd55d93d8b@quicinc.com \
--to=quic_zijuhu@quicinc.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=wt@penguintechs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.