From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<luiz.dentz@gmail.com>, <luiz.von.dentz@intel.com>,
<marcel@holtmann.org>
Cc: <linux-bluetooth@vger.kernel.org>,
<bartosz.golaszewski@linaro.org>, <wt@penguintechs.org>,
<regressions@lists.linux.dev>
Subject: Re: [PATCH v5 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot
Date: Mon, 22 Apr 2024 20:59:27 +0800 [thread overview]
Message-ID: <9ac11453-b7cf-43f3-8e46-f96e41ef190d@quicinc.com> (raw)
In-Reply-To: <01b0f63e-55f0-4396-bb8b-521bbe9b060e@linaro.org>
On 4/22/2024 8:22 PM, Krzysztof Kozlowski wrote:
> On 22/04/2024 13:25, quic_zijuhu wrote:
>> On 4/22/2024 3:42 PM, Krzysztof Kozlowski wrote:
>>> On 22/04/2024 09:38, Zijun Hu wrote:
>>>> From: Zijun Hu <zijuhu@qti.qualcomm.com>
>>>>
>>>> Commit 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed
>>>> serdev") will cause below regression issue:
>>>>
>>>> BT can't be enabled after below steps:
>>>> cold boot -> enable BT -> disable BT -> warm reboot -> BT enable failure
>>>> if property enable-gpios is not configured within DT|ACPI for QCA_QCA6390.
>>>>
>>>> The commit is to fix a use-after-free issue within qca_serdev_shutdown()
>>>> during reboot, but also introduces this new issue regarding above steps
>>>> since the VSC is not sent to reset controller during warm reboot.
>>>>
>>>> Fixed by sending the VSC to reset controller within qca_serdev_shutdown()
>>>> once BT was ever enabled, and the use-after-free issue is also be fixed
>>>> by this change since serdev is still opened when send to serdev.
>>>>
>>>> Fixes: 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed serdev")
>>>> Reported-by: Wren Turkal <wt@penguintechs.org>
>>>
>>> NAK. This is way too much. Previous discussion is going, I asked there
>>> questions and before any answers happen, you keep sending new version.
>>> This leads to previous discussion gone/missed.
>>>
>>> You ignored several questions and feedbacks.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> i believe my commit message explains WHAT/WHY/HOW about this issue.
>>
>> 1) the qca_serdev_shutdown() was introduced by my below commit
>> Commit 7e7bbddd029b ("Bluetooth: hci_qca: Fix qca6390 enable failure
>> after warm reboot")
>>
>> 2) then Krzysztof's below commit was made to fix use-after-free issue
>> but also causes discussed regression issue.
>> Commit 0b7015132878 ("Bluetooth: btusb: mediatek: add MediaTek
>> devcoredump support")
>>
>> 3) my fix will solve both this issue and the use-after-free issue.
>
> I had to keep reminding you about answering to question multiple times.
> So one more time:
>
>> You did not address original issue of crash during shutdown and did
> not clarify my questions.
>
let me explain here. original crash your commit fixed should only
happens with machine for which property enable-gpios is configured,
which also results in quirk HCI_QUIRK_NON_PERSISTENT_SETUP is set. for
this case. for this case, serdev has been closed when
qca_serdev_shutdown() write the VSC to serdev, so cause the crash.
your commit fix this issue for this cause but cause regression for the
case my commit message described.
>> Anyway, any explanation providing background how you are fixing this
> issue while keeping *previous problem fixed* is useful but should be
> provided in commit msg. I asked about this two or three times.
>
i have provided it in this v5 commit.
>> BTW, provide here exact kernel version you tested this patches with.
> Also the exact hardware.
>
we can provide the kernel version in the bugzilla, as explained above,
for the same soc_type, different machine have different config.
different config have different result.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-04-22 12:59 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:06 [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-18 14:06 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Zijun Hu
2024-04-18 14:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-18 16:52 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Krzysztof Kozlowski
2024-04-18 21:16 ` quic_zijuhu
2024-04-18 22:37 ` Krzysztof Kozlowski
2024-04-18 23:17 ` quic_zijuhu
2024-04-19 13:49 ` Krzysztof Kozlowski
2024-04-20 5:25 ` quic_zijuhu
2024-04-20 5:27 ` quic_zijuhu
2024-04-20 11:13 ` Krzysztof Kozlowski
2024-04-20 23:01 ` quic_zijuhu
2024-04-18 17:00 ` Bartosz Golaszewski
2024-04-18 21:43 ` quic_zijuhu
2024-04-18 22:42 ` Bartosz Golaszewski
2024-04-18 23:36 ` quic_zijuhu
2024-04-19 21:27 ` Bartosz Golaszewski
2024-04-20 5:39 ` quic_zijuhu
2024-04-21 7:14 ` Wren Turkal
2024-04-21 9:40 ` quic_zijuhu
2024-04-22 5:26 ` Wren Turkal
2024-04-18 14:06 ` [PATCH v1 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-18 16:48 ` Krzysztof Kozlowski
2024-04-18 20:34 ` quic_zijuhu
2024-04-18 20:58 ` Krzysztof Kozlowski
2024-04-18 22:05 ` quic_zijuhu
2024-04-18 22:38 ` Krzysztof Kozlowski
2024-04-18 23:24 ` quic_zijuhu
2024-04-19 21:48 ` [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 21:48 ` [PATCH v2 1/2] Bluetooth: MGMT: Fix failing to MGMT_OP_ADD_UUID/MGMT_OP_REMOVE_UUID Zijun Hu
2024-04-19 22:05 ` quic_zijuhu
2024-04-19 22:12 ` [v2,1/2] " bluez.test.bot
2024-04-19 21:48 ` [PATCH v2 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:06 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 22:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:30 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 11:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Krzysztof Kozlowski
2024-04-20 21:28 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-20 11:07 ` Krzysztof Kozlowski
2024-04-20 21:42 ` quic_zijuhu
2024-04-20 11:01 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Krzysztof Kozlowski
2024-04-22 7:44 ` Krzysztof Kozlowski
2024-04-22 8:07 ` quic_zijuhu
2024-04-22 8:11 ` Krzysztof Kozlowski
2024-04-22 8:21 ` quic_zijuhu
2024-04-20 22:06 ` [PATCH v4 " Zijun Hu
2024-04-20 22:06 ` [PATCH v4 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-20 22:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 22:06 ` [PATCH v4 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-21 7:44 ` [PATCH v4 0/2] Fix two regression issues for QCA controllers Wren Turkal
2024-04-21 9:30 ` quic_zijuhu
2024-04-21 18:41 ` Krzysztof Kozlowski
2024-04-22 0:14 ` quic_zijuhu
2024-04-22 5:21 ` Wren Turkal
2024-04-22 8:51 ` Bartosz Golaszewski
2024-04-22 10:42 ` Wren Turkal
2024-04-22 13:02 ` Bartosz Golaszewski
2024-04-24 1:52 ` Wren Turkal
2024-04-22 5:52 ` Krzysztof Kozlowski
2024-04-22 6:00 ` quic_zijuhu
2024-04-22 7:45 ` Krzysztof Kozlowski
2024-04-22 10:05 ` quic_zijuhu
2024-04-22 12:28 ` Krzysztof Kozlowski
2024-04-21 13:51 ` Krzysztof Kozlowski
2024-04-22 7:38 ` [PATCH v5 " Zijun Hu
2024-04-22 7:38 ` [PATCH v5 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-22 8:36 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-22 7:38 ` [PATCH v5 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-22 7:42 ` Krzysztof Kozlowski
2024-04-22 11:25 ` quic_zijuhu
2024-04-22 12:22 ` Krzysztof Kozlowski
2024-04-22 12:59 ` quic_zijuhu [this message]
2024-04-25 0:59 ` [PATCH v6 v7] Fix two BT regression issues for QCA6390 Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ac11453-b7cf-43f3-8e46-f96e41ef190d@quicinc.com \
--to=quic_zijuhu@quicinc.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=regressions@lists.linux.dev \
--cc=wt@penguintechs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.