From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wren Turkal <wt@penguintechs.org>,
Zijun Hu <quic_zijuhu@quicinc.com>,
luiz.dentz@gmail.com, luiz.von.dentz@intel.com,
marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org, bartosz.golaszewski@linaro.org
Subject: Re: [PATCH v4 0/2] Fix two regression issues for QCA controllers
Date: Sun, 21 Apr 2024 20:41:14 +0200 [thread overview]
Message-ID: <a6ae69ad-b602-4cfc-9f76-8932f357d30b@kernel.org> (raw)
In-Reply-To: <369512e2-f091-4370-bce5-9ac32178dc4d@penguintechs.org>
On 21/04/2024 09:44, Wren Turkal wrote:
> On 4/20/24 3:06 PM, Zijun Hu wrote:
>> This patch series are to fix below 2 regression issues for QCA controllers
>> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390
>> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390
>
> @Zijun @Krzysztof and @Bartosz Would it be helpful for me to test these
> to ensure they fix the issues I reported?
>
I look forward to someone testing these on other hardware, not yours. On
the hardware where the original issues were happening leading to this
changes, e.g. RB5.
Anyway, the problem here is poor explanation of the problem which did
not improve in v3 and v4. Instead I receive explanations like:
"this is shutdown of serdev and not hdev's shutdown."
Not related...
"now. you understood why your merged change as shown link of 4) have
problems and introduced our discussed issue, right?"
No. I did not understand and I feel I am wasting here time.
Code could be correct, could be wrong. Especially second patch looks
suspicious. But the way Zijun Hu explains it and the way Zijun Hu
responds is not helping at all.
Sorry, with such replies to review, it is not worth my time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-21 18:41 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:06 [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-18 14:06 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Zijun Hu
2024-04-18 14:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-18 16:52 ` [PATCH v1 1/2] Revert "Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()" Krzysztof Kozlowski
2024-04-18 21:16 ` quic_zijuhu
2024-04-18 22:37 ` Krzysztof Kozlowski
2024-04-18 23:17 ` quic_zijuhu
2024-04-19 13:49 ` Krzysztof Kozlowski
2024-04-20 5:25 ` quic_zijuhu
2024-04-20 5:27 ` quic_zijuhu
2024-04-20 11:13 ` Krzysztof Kozlowski
2024-04-20 23:01 ` quic_zijuhu
2024-04-18 17:00 ` Bartosz Golaszewski
2024-04-18 21:43 ` quic_zijuhu
2024-04-18 22:42 ` Bartosz Golaszewski
2024-04-18 23:36 ` quic_zijuhu
2024-04-19 21:27 ` Bartosz Golaszewski
2024-04-20 5:39 ` quic_zijuhu
2024-04-21 7:14 ` Wren Turkal
2024-04-21 9:40 ` quic_zijuhu
2024-04-22 5:26 ` Wren Turkal
2024-04-18 14:06 ` [PATCH v1 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-18 16:48 ` Krzysztof Kozlowski
2024-04-18 20:34 ` quic_zijuhu
2024-04-18 20:58 ` Krzysztof Kozlowski
2024-04-18 22:05 ` quic_zijuhu
2024-04-18 22:38 ` Krzysztof Kozlowski
2024-04-18 23:24 ` quic_zijuhu
2024-04-19 21:48 ` [PATCH v1 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 21:48 ` [PATCH v2 1/2] Bluetooth: MGMT: Fix failing to MGMT_OP_ADD_UUID/MGMT_OP_REMOVE_UUID Zijun Hu
2024-04-19 22:05 ` quic_zijuhu
2024-04-19 22:12 ` [v2,1/2] " bluez.test.bot
2024-04-19 21:48 ` [PATCH v2 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:06 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Zijun Hu
2024-04-19 22:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-19 22:30 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 11:03 ` [PATCH v3 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Krzysztof Kozlowski
2024-04-20 21:28 ` quic_zijuhu
2024-04-19 22:03 ` [PATCH v3 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-20 11:07 ` Krzysztof Kozlowski
2024-04-20 21:42 ` quic_zijuhu
2024-04-20 11:01 ` [PATCH v3 0/2] Fix two regression issues for QCA controllers Krzysztof Kozlowski
2024-04-22 7:44 ` Krzysztof Kozlowski
2024-04-22 8:07 ` quic_zijuhu
2024-04-22 8:11 ` Krzysztof Kozlowski
2024-04-22 8:21 ` quic_zijuhu
2024-04-20 22:06 ` [PATCH v4 " Zijun Hu
2024-04-20 22:06 ` [PATCH v4 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-20 22:31 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-20 22:06 ` [PATCH v4 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-21 7:44 ` [PATCH v4 0/2] Fix two regression issues for QCA controllers Wren Turkal
2024-04-21 9:30 ` quic_zijuhu
2024-04-21 18:41 ` Krzysztof Kozlowski [this message]
2024-04-22 0:14 ` quic_zijuhu
2024-04-22 5:21 ` Wren Turkal
2024-04-22 8:51 ` Bartosz Golaszewski
2024-04-22 10:42 ` Wren Turkal
2024-04-22 13:02 ` Bartosz Golaszewski
2024-04-24 1:52 ` Wren Turkal
2024-04-22 5:52 ` Krzysztof Kozlowski
2024-04-22 6:00 ` quic_zijuhu
2024-04-22 7:45 ` Krzysztof Kozlowski
2024-04-22 10:05 ` quic_zijuhu
2024-04-22 12:28 ` Krzysztof Kozlowski
2024-04-21 13:51 ` Krzysztof Kozlowski
2024-04-22 7:38 ` [PATCH v5 " Zijun Hu
2024-04-22 7:38 ` [PATCH v5 1/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Zijun Hu
2024-04-22 8:36 ` Fix two regression issues for QCA controllers bluez.test.bot
2024-04-22 7:38 ` [PATCH v5 2/2] Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot Zijun Hu
2024-04-22 7:42 ` Krzysztof Kozlowski
2024-04-22 11:25 ` quic_zijuhu
2024-04-22 12:22 ` Krzysztof Kozlowski
2024-04-22 12:59 ` quic_zijuhu
2024-04-25 0:59 ` [PATCH v6 v7] Fix two BT regression issues for QCA6390 Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ae69ad-b602-4cfc-9f76-8932f357d30b@kernel.org \
--to=krzk@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
--cc=wt@penguintechs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.