clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] clogger.c: comment to explain the lack of GC guard
@ 2017-01-17 19:22 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-01-17 19:22 UTC (permalink / raw)
  To: clogger-public; +Cc: Eric Wong

If I (the person who wrote this) spent a minute figuring out why
it wasn't needed, somebody else might, too.  Save someone else
a minute.
---
 ext/clogger_ext/clogger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ext/clogger_ext/clogger.c b/ext/clogger_ext/clogger.c
index f29cf26..83ce76a 100644
--- a/ext/clogger_ext/clogger.c
+++ b/ext/clogger_ext/clogger.c
@@ -682,6 +682,7 @@ static VALUE cwrite(struct clogger *c)
 
 	if (c->fd >= 0) {
 		write_full(c->fd, RSTRING_PTR(dst), RSTRING_LEN(dst));
+		/* no need for RB_GC_GUARD(dst) here, marked as c->log_buf */
 	} else {
 		VALUE logger = c->logger;
 
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-01-17 19:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-17 19:22 [PATCH] clogger.c: comment to explain the lack of GC guard Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../clogger.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).