Re: Test failure caused by commit 377028d99

[Eric Wong <normalperson@yhbt.net>]

Hleb Valoshka <375gnu@gmail.com> wrote:
> On my Debian Sid with kernel 3.11-rc7 4 of 5 invocations of
> test_poll_EINTR_changed finished with failure:

Thanks for the report.  Unfortunately, I can't seem to reproduce it,
here on 1.9.3 nor 2.0.0 with Linux 3.10.10.

The test will probably not work well under heavy load, and I've
considered removing it, even.  Current behavior may not be compatible
with all Ruby versions depending on how signal handling is implemented.

Does the following change increase reliability for you?

--- a/test/test_poll.rb
+++ b/test/test_poll.rb
@@ -96,7 +96,10 @@ def test_poll_EINTR_changed
     end
     thr = Thread.new do
       sleep 0.100
-      Process.kill(:USR1, $$)
+      100.times do
+        Process.kill(:USR1, $$)
+        Thread.pass
+      end
     end
     t0 = Time.now
     res = Kgio.poll(pollset, 1000)

If not, I think we can just drop the test...