Re: Test failure caused by commit 377028d99

[Eric Wong <normalperson@yhbt.net>]

Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/6/13, Eric Wong <normalperson@yhbt.net> wrote:
> >> > Does the following change increase reliability for you?
> >> Yes, it helps. Thanks.
> > Thanks for testing, pushed as
> > commit ff940137dc5098c9d8094e041e9be053cb3e139f
> 
> Another problem has emerged :) Sometimes ruby delivers signals too
> late and this test dies because of unhandled USR1. At least Ruby2.0 is
> affected (I have no problem with this test under Ruby1.9.3). May be
> it's better to remove it.

Ugh, yes, this is tricky to test...
Does the following help?

diff --git a/test/test_poll.rb b/test/test_poll.rb
index d9a2b07..5c8071d 100644
--- a/test/test_poll.rb
+++ b/test/test_poll.rb
@@ -108,6 +108,8 @@ class TestPoll < Test::Unit::TestCase
     assert_equal({@wr => Kgio::POLLOUT}, res)
     assert diff < 1.0, "diff=#{diff}"
     assert ok
+
+    1000.times { Thread.pass } # let signal handlers fire
     ensure
       trap(:USR1, orig)
   end


(I'm sleepy myself and thinking out loud)
Or it could be just made to sleep (and slow down the tests even more)
Thanks!