From: kajoljain <kjain@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Weiny, Ira" <ira.weiny@intel.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
maddy@linux.ibm.com, Santosh Sivaraj <santosh@fossix.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
atrajeev@linux.vnet.ibm.com, Thomas Gleixner <tglx@linutronix.de>,
rnsastry@linux.ibm.com
Subject: Re: [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries
Date: Thu, 9 Sep 2021 13:33:22 +0530 [thread overview]
Message-ID: <09823156-2797-af1d-23ce-d31ae86770d9@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4h-MgZmteMSUfdeQL+XCxL5HvxK87HA3JYB0OoQUaPipQ@mail.gmail.com>
On 9/8/21 6:33 AM, Dan Williams wrote:
> On Thu, Sep 2, 2021 at 10:11 PM Kajol Jain <kjain@linux.ibm.com> wrote:
>>
>> Details is added for the event, cpumask and format attributes
>> in the ABI documentation.
>>
>> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>> Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>> Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>> ---
>> Documentation/ABI/testing/sysfs-bus-papr-pmem | 31 +++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-papr-pmem b/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> index 95254cec92bf..4d86252448f8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> +++ b/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> @@ -61,3 +61,34 @@ Description:
>> * "CchRHCnt" : Cache Read Hit Count
>> * "CchWHCnt" : Cache Write Hit Count
>> * "FastWCnt" : Fast Write Count
>> +
>> +What: /sys/devices/nmemX/format
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) Attribute group to describe the magic bits
>> + that go into perf_event_attr.config for a particular pmu.
>> + (See ABI/testing/sysfs-bus-event_source-devices-format).
>> +
>> + Each attribute under this group defines a bit range of the
>> + perf_event_attr.config. Supported attribute is listed
>> + below::
>> +
>> + event = "config:0-4" - event ID
>> +
>> + For example::
>> + noopstat = "event=0x1"
>> +
>> +What: /sys/devices/nmemX/events
>
> That's not a valid sysfs path. Did you mean /sys/bus/nd/devices/nmemX?
Hi Dan,
Thanks, I will correct it and update it to `/sys/bus/event_source/devices/`
where perf creates sysfs files for given pmu.
>
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) Attribute group to describe performance monitoring
>> + events specific to papr-scm. Each attribute in this group describes
>> + a single performance monitoring event supported by this nvdimm pmu.
>> + The name of the file is the name of the event.
>> + (See ABI/testing/sysfs-bus-event_source-devices-events).
>
> Given these events are in the generic namespace the ABI documentation
> should be generic as well. So I think move these entries to
> Documentation/ABI/testing/sysfs-bus-nvdimm directly.
>
> You can still mention papr-scm, but I would expect something like:
>
> What: /sys/bus/nd/devices/nmemX/events
> Date: September 2021
> KernelVersion: 5.16
> Contact: Kajol Jain <kjain@linux.ibm.com>
> Description:
> (RO) Attribute group to describe performance monitoring events
> for the nvdimm memory device. Each attribute in this group
> describes a single performance monitoring event supported by
> this nvdimm pmu. The name of the file is the name of the event.
> (See ABI/testing/sysfs-bus-event_source-devices-events). A
> listing of the events supported by a given nvdimm provider type
> can be found in Documentation/driver-api/nvdimm/$provider, for
> example: Documentation/driver-api/nvdimm/papr-scm.
>
>
I will update it accordingly.
>
>> +
>> +What: /sys/devices/nmemX/cpumask
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) This sysfs file exposes the cpumask which is designated to make
>> + HCALLs to retrieve nvdimm pmu event counter data.
>
> Seems this one would be provider generic, so no need to refer to PPC
> specific concepts like HCALLs.
>
Sure will update it.
Thanks,
Kajol Jain
WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux NVDIMM <nvdimm@lists.linux.dev>,
Santosh Sivaraj <santosh@fossix.org>,
maddy@linux.ibm.com, "Weiny, Ira" <ira.weiny@intel.com>,
rnsastry@linux.ibm.com, Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
atrajeev@linux.vnet.ibm.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Vishal L Verma <vishal.l.verma@intel.com>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries
Date: Thu, 9 Sep 2021 13:33:22 +0530 [thread overview]
Message-ID: <09823156-2797-af1d-23ce-d31ae86770d9@linux.ibm.com> (raw)
In-Reply-To: <CAPcyv4h-MgZmteMSUfdeQL+XCxL5HvxK87HA3JYB0OoQUaPipQ@mail.gmail.com>
On 9/8/21 6:33 AM, Dan Williams wrote:
> On Thu, Sep 2, 2021 at 10:11 PM Kajol Jain <kjain@linux.ibm.com> wrote:
>>
>> Details is added for the event, cpumask and format attributes
>> in the ABI documentation.
>>
>> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>> Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>
>> Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
>> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
>> ---
>> Documentation/ABI/testing/sysfs-bus-papr-pmem | 31 +++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-papr-pmem b/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> index 95254cec92bf..4d86252448f8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> +++ b/Documentation/ABI/testing/sysfs-bus-papr-pmem
>> @@ -61,3 +61,34 @@ Description:
>> * "CchRHCnt" : Cache Read Hit Count
>> * "CchWHCnt" : Cache Write Hit Count
>> * "FastWCnt" : Fast Write Count
>> +
>> +What: /sys/devices/nmemX/format
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) Attribute group to describe the magic bits
>> + that go into perf_event_attr.config for a particular pmu.
>> + (See ABI/testing/sysfs-bus-event_source-devices-format).
>> +
>> + Each attribute under this group defines a bit range of the
>> + perf_event_attr.config. Supported attribute is listed
>> + below::
>> +
>> + event = "config:0-4" - event ID
>> +
>> + For example::
>> + noopstat = "event=0x1"
>> +
>> +What: /sys/devices/nmemX/events
>
> That's not a valid sysfs path. Did you mean /sys/bus/nd/devices/nmemX?
Hi Dan,
Thanks, I will correct it and update it to `/sys/bus/event_source/devices/`
where perf creates sysfs files for given pmu.
>
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) Attribute group to describe performance monitoring
>> + events specific to papr-scm. Each attribute in this group describes
>> + a single performance monitoring event supported by this nvdimm pmu.
>> + The name of the file is the name of the event.
>> + (See ABI/testing/sysfs-bus-event_source-devices-events).
>
> Given these events are in the generic namespace the ABI documentation
> should be generic as well. So I think move these entries to
> Documentation/ABI/testing/sysfs-bus-nvdimm directly.
>
> You can still mention papr-scm, but I would expect something like:
>
> What: /sys/bus/nd/devices/nmemX/events
> Date: September 2021
> KernelVersion: 5.16
> Contact: Kajol Jain <kjain@linux.ibm.com>
> Description:
> (RO) Attribute group to describe performance monitoring events
> for the nvdimm memory device. Each attribute in this group
> describes a single performance monitoring event supported by
> this nvdimm pmu. The name of the file is the name of the event.
> (See ABI/testing/sysfs-bus-event_source-devices-events). A
> listing of the events supported by a given nvdimm provider type
> can be found in Documentation/driver-api/nvdimm/$provider, for
> example: Documentation/driver-api/nvdimm/papr-scm.
>
>
I will update it accordingly.
>
>> +
>> +What: /sys/devices/nmemX/cpumask
>> +Date: June 2021
>> +Contact: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, nvdimm@lists.linux.dev,
>> +Description: (RO) This sysfs file exposes the cpumask which is designated to make
>> + HCALLs to retrieve nvdimm pmu event counter data.
>
> Seems this one would be provider generic, so no need to refer to PPC
> specific concepts like HCALLs.
>
Sure will update it.
Thanks,
Kajol Jain
next prev parent reply other threads:[~2021-09-09 8:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 5:09 [RESEND PATCH v4 0/4] Add perf interface to expose nvdimm Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 5:09 ` [RESEND PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-07 21:59 ` Dan Williams
2021-09-07 21:59 ` Dan Williams
2021-09-09 7:55 ` kajoljain
2021-09-09 7:55 ` kajoljain
2021-09-15 4:08 ` Dan Williams
2021-09-15 4:08 ` Dan Williams
2021-09-15 4:11 ` Dan Williams
2021-09-15 4:11 ` Dan Williams
2021-09-03 5:09 ` [RESEND PATCH v4 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 12:32 ` kernel test robot
2021-09-03 12:32 ` kernel test robot
2021-09-03 12:32 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-04 6:38 ` kajoljain
2021-09-04 6:38 ` kajoljain
2021-09-04 6:38 ` kajoljain
2021-09-03 15:19 ` [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-04 6:39 ` kajoljain
2021-09-04 6:39 ` kajoljain
2021-09-04 6:39 ` kajoljain
2021-09-03 5:09 ` [RESEND PATCH v4 3/4] powerpc/papr_scm: Add perf interface support Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 5:09 ` [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-08 1:03 ` Dan Williams
2021-09-08 1:03 ` Dan Williams
2021-09-09 8:03 ` kajoljain [this message]
2021-09-09 8:03 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09823156-2797-af1d-23ce-d31ae86770d9@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rnsastry@linux.ibm.com \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
--cc=vaibhav@linux.ibm.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.