From: kajoljain <kjain@linux.ibm.com>
To: kernel test robot <lkp@intel.com>,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
peterz@infradead.org, dan.j.williams@intel.com,
ira.weiny@intel.com, vishal.l.verma@intel.com
Cc: kbuild-all@lists.01.org, maddy@linux.ibm.com, santosh@fossix.org
Subject: Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static
Date: Sat, 4 Sep 2021 12:09:59 +0530 [thread overview]
Message-ID: <2d314a25-8972-3a01-9402-d43e41177a8f@linux.ibm.com> (raw)
In-Reply-To: <20210903151941.GA23182@a0af9ae1a611>
On 9/3/21 8:49 PM, kernel test robot wrote:
> drivers/nvdimm/nd_perf.c:159:6: warning: symbol 'nvdimm_pmu_free_hotplug_memory' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> nd_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 4c49d1bc2a3c6..b129e5e702d59 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -156,7 +156,7 @@ static int nvdimm_pmu_cpu_hotplug_init(struct nvdimm_pmu *nd_pmu)
> return 0;
> }
>
> -void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> +static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> {
> cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
> cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
>
Hi,
Thanks for reporting this issue, I will merge it in my followup patchset.
Thanks,
Kajol Jain
WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com>
To: kernel test robot <lkp@intel.com>,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
peterz@infradead.org, dan.j.williams@intel.com,
ira.weiny@intel.com, vishal.l.verma@intel.com
Cc: santosh@fossix.org, maddy@linux.ibm.com, kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static
Date: Sat, 4 Sep 2021 12:09:59 +0530 [thread overview]
Message-ID: <2d314a25-8972-3a01-9402-d43e41177a8f@linux.ibm.com> (raw)
In-Reply-To: <20210903151941.GA23182@a0af9ae1a611>
On 9/3/21 8:49 PM, kernel test robot wrote:
> drivers/nvdimm/nd_perf.c:159:6: warning: symbol 'nvdimm_pmu_free_hotplug_memory' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> nd_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 4c49d1bc2a3c6..b129e5e702d59 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -156,7 +156,7 @@ static int nvdimm_pmu_cpu_hotplug_init(struct nvdimm_pmu *nd_pmu)
> return 0;
> }
>
> -void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> +static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> {
> cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
> cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
>
Hi,
Thanks for reporting this issue, I will merge it in my followup patchset.
Thanks,
Kajol Jain
WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static
Date: Sat, 04 Sep 2021 12:09:59 +0530 [thread overview]
Message-ID: <2d314a25-8972-3a01-9402-d43e41177a8f@linux.ibm.com> (raw)
In-Reply-To: <20210903151941.GA23182@a0af9ae1a611>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On 9/3/21 8:49 PM, kernel test robot wrote:
> drivers/nvdimm/nd_perf.c:159:6: warning: symbol 'nvdimm_pmu_free_hotplug_memory' was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> nd_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/nd_perf.c b/drivers/nvdimm/nd_perf.c
> index 4c49d1bc2a3c6..b129e5e702d59 100644
> --- a/drivers/nvdimm/nd_perf.c
> +++ b/drivers/nvdimm/nd_perf.c
> @@ -156,7 +156,7 @@ static int nvdimm_pmu_cpu_hotplug_init(struct nvdimm_pmu *nd_pmu)
> return 0;
> }
>
> -void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> +static void nvdimm_pmu_free_hotplug_memory(struct nvdimm_pmu *nd_pmu)
> {
> cpuhp_state_remove_instance_nocalls(nd_pmu->cpuhp_state, &nd_pmu->node);
> cpuhp_remove_multi_state(nd_pmu->cpuhp_state);
>
Hi,
Thanks for reporting this issue, I will merge it in my followup patchset.
Thanks,
Kajol Jain
next prev parent reply other threads:[~2021-09-04 6:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 5:09 [RESEND PATCH v4 0/4] Add perf interface to expose nvdimm Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 5:09 ` [RESEND PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-07 21:59 ` Dan Williams
2021-09-07 21:59 ` Dan Williams
2021-09-09 7:55 ` kajoljain
2021-09-09 7:55 ` kajoljain
2021-09-15 4:08 ` Dan Williams
2021-09-15 4:08 ` Dan Williams
2021-09-15 4:11 ` Dan Williams
2021-09-15 4:11 ` Dan Williams
2021-09-03 5:09 ` [RESEND PATCH v4 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 12:32 ` kernel test robot
2021-09-03 12:32 ` kernel test robot
2021-09-03 12:32 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-04 6:38 ` kajoljain
2021-09-04 6:38 ` kajoljain
2021-09-04 6:38 ` kajoljain
2021-09-03 15:19 ` [RFC PATCH] drivers/nvdimm: nvdimm_pmu_free_hotplug_memory() can be static kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-03 15:19 ` kernel test robot
2021-09-04 6:39 ` kajoljain [this message]
2021-09-04 6:39 ` kajoljain
2021-09-04 6:39 ` kajoljain
2021-09-03 5:09 ` [RESEND PATCH v4 3/4] powerpc/papr_scm: Add perf interface support Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-03 5:09 ` [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries Kajol Jain
2021-09-03 5:09 ` Kajol Jain
2021-09-08 1:03 ` Dan Williams
2021-09-08 1:03 ` Dan Williams
2021-09-09 8:03 ` kajoljain
2021-09-09 8:03 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d314a25-8972-3a01-9402-d43e41177a8f@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=santosh@fossix.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.