From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Frank Li <Frank.li@nxp.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
imx@lists.linux.dev, "Richard Zhu" <hongxing.zhu@nxp.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
bpf@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config
Date: Thu, 29 Feb 2024 08:29:47 +0100 [thread overview]
Message-ID: <0d03e5d4-12d0-4cc5-b17c-692471ee3c2d@pengutronix.de> (raw)
In-Reply-To: <Zd/DlibuoSxvjPW5@lizhi-Precision-Tower-5810>
Hello Frank,
On 29.02.24 00:36, Frank Li wrote:
> On Wed, Feb 28, 2024 at 05:05:20PM -0600, Bjorn Helgaas wrote:
>> On Tue, Feb 27, 2024 at 04:47:09PM -0500, Frank Li wrote:
>>> -config PCI_IMX6
>>> +config PCI_IMX
>>
>> What does this look like to users who carry an old .config file
>> forward?
>
> I don't think people will use old .config when update to new kernel. I can
> keep PCI_IMX6 for config if have to.
I'd argue it's the complete opposite. Most users don't use the in-tree defconfig,
but use olddefconfig on their customized .config, either explicitly or
implicitly via menuconfig and saving.
This would result in non-functional PCI after an update. I don't mind renaming
the file, but please leave the Kconfig symbol as-is.
Thanks,
Ahmad
>
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Frank Li <Frank.li@nxp.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
imx@lists.linux.dev, "Richard Zhu" <hongxing.zhu@nxp.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
bpf@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config
Date: Thu, 29 Feb 2024 08:29:47 +0100 [thread overview]
Message-ID: <0d03e5d4-12d0-4cc5-b17c-692471ee3c2d@pengutronix.de> (raw)
In-Reply-To: <Zd/DlibuoSxvjPW5@lizhi-Precision-Tower-5810>
Hello Frank,
On 29.02.24 00:36, Frank Li wrote:
> On Wed, Feb 28, 2024 at 05:05:20PM -0600, Bjorn Helgaas wrote:
>> On Tue, Feb 27, 2024 at 04:47:09PM -0500, Frank Li wrote:
>>> -config PCI_IMX6
>>> +config PCI_IMX
>>
>> What does this look like to users who carry an old .config file
>> forward?
>
> I don't think people will use old .config when update to new kernel. I can
> keep PCI_IMX6 for config if have to.
I'd argue it's the complete opposite. Most users don't use the in-tree defconfig,
but use olddefconfig on their customized .config, either explicitly or
implicitly via menuconfig and saving.
This would result in non-functional PCI after an update. I don't mind renaming
the file, but please leave the Kconfig symbol as-is.
Thanks,
Ahmad
>
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-29 7:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:47 [PATCH 0/6] PCI: imx6: rename\clean up and add lut information for imx95 Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-27 21:47 ` [PATCH 1/6] PCI: imx6: Rename imx6_* with imx_* Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-28 23:14 ` Fabio Estevam
2024-02-28 23:14 ` Fabio Estevam
2024-02-28 23:31 ` Frank Li
2024-02-28 23:31 ` Frank Li
2024-02-27 21:47 ` [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-28 23:05 ` Bjorn Helgaas
2024-02-28 23:05 ` Bjorn Helgaas
2024-02-28 23:36 ` Frank Li
2024-02-28 23:36 ` Frank Li
2024-02-29 7:29 ` Ahmad Fatoum [this message]
2024-02-29 7:29 ` Ahmad Fatoum
2024-03-01 7:16 ` kernel test robot
2024-03-01 7:16 ` kernel test robot
2024-02-27 21:47 ` [PATCH 3/6] MAINTAINERS: pci: imx: update imx6* to imx* since rename driver file Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-27 21:47 ` [PATCH 4/6] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-27 21:47 ` [PATCH 5/6] PCI: imx: Simplify switch-case logic by involve core_reset callback Frank Li
2024-02-27 21:47 ` Frank Li
2024-02-27 21:47 ` [PATCH 6/6] PCI: imx: Config look up table(LUT) to support MSI ITS and IOMMU for i.MX95 Frank Li
2024-02-27 21:47 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d03e5d4-12d0-4cc5-b17c-692471ee3c2d@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=Frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.