Re: [PATCH 1/6] PCI: imx6: Rename imx6_* with imx_*

From: Frank Li <Frank.li@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Richard Zhu" <hongxing.zhu@nxp.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-pci@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 1/6] PCI: imx6: Rename imx6_* with imx_*
Date: Wed, 28 Feb 2024 18:31:20 -0500	[thread overview]
Message-ID: <Zd/CSFU/FBsp803i@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <CAOMZO5C-01=jYbJTgQucfD8+pT-chy4xvQMckUee1O+gtE-0pQ@mail.gmail.com>

On Wed, Feb 28, 2024 at 08:14:16PM -0300, Fabio Estevam wrote:
> On Tue, Feb 27, 2024 at 6:47 PM Frank Li <Frank.Li@nxp.com> wrote:
> >
> > imx6_* actually mean for all imx chips (imx6x, imx7x, imx8x and imx9x).
> 
> That's OK. In the kernel, we have lots of examples where the names of
> files and functions follow the first chip model.
> 
> If this same IP gets used by another SoC in the future that is not
> named i.MX, will this driver get renamed again?

It will depend on the how much difference. We can't predict future. We will
discuss at that time.

We use dwc IP. Only difference was external glue logic. layerscape use
difference files.

> 
> > Rename imx6_* with imx_* to avoid confuse.
> 
> I don't find it confusing.

If you follow next patches, you will be confused. Some function will use
imx7_xxx_reset(), imx8_xxx_reset. We will add more soc support.

It was not easy to distinguish imx6_xxx is for all imx6 chips or all imx
chips. If you are expert at imx chips, any name should be okay. Good naming
will help for all reviewer and contributor.

Frank

> 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pci-imx6.c | 754 +++++++++++++++++-----------------
> >  1 file changed, 377 insertions(+), 377 deletions(-)
> 
> I think this pure churn and we should not do the rename as it brings
> no benefits.