From: Paul Bolle <pebolle@tiscali.nl>
To: Shobhit Kumar <kumar@shobhit.info>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>,
linux-pwm <linux-pwm@vger.kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Alexandre Courbot <gnurou@gmail.com>,
David Airlie <airlied@linux.ie>,
Povilas Staniulis <wdmonster@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Chih-Wei Huang <cwhuang@android-x86.org>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver
Date: Thu, 18 Jun 2015 20:41:56 +0200 [thread overview]
Message-ID: <1434652916.2385.124.camel@x220> (raw)
In-Reply-To: <CAAbrOmc-71MO2N9sezbOONPAf8_XSCOtHBSGD9AS9hOk0vsE=A@mail.gmail.com>
Hi Shobhit,
On Thu, 2015-06-18 at 23:24 +0530, Shobhit Kumar wrote:
> On Fri, May 1, 2015 at 2:42 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > On Wed, 2015-04-29 at 19:30 +0530, Shobhit Kumar wrote:
> >> --- a/drivers/pwm/Kconfig
> >> +++ b/drivers/pwm/Kconfig
> >
> >> +config PWM_CRC
> >> + bool "Intel Crystalcove (CRC) PWM support"
> >> + depends on X86 && INTEL_SOC_PMIC
> >> + help
> >> + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM
> >> + control.
> >
> >> --- a/drivers/pwm/Makefile
> >> +++ b/drivers/pwm/Makefile
> >
> >> +obj-$(CONFIG_PWM_CRC) += pwm-crc.o
> >
> > PWM_CRC is a bool symbol. So pwm-crc.o can never be part of a module.
>
> I actually started this as a module but later decided to make it as
> bool because INTEL_SOC_PMIC on which this depends is itself a bool as
> well.
As does GPIO_CRYSTAL_COVE and that's a tristate. So?
> Still it is good to keep the module based initialization.
> Firstly because it causes no harm
If I got a dime for every time people used an argument like that I ... I
could treat myself to an ice cream. A really big ice cream. Hmm, that
doesn't sound too impressive. But still, "causes no harm" is below the
bar for kernel code. Kernel code needs to add value.
> and even though some of the macros
> are pre-processed out, gives info about the driver.
None of which can't be gotten elsewhere (ie, the commit message, or the
file these macro reside in).
> Secondly there
> were discussion on why INTEL_SOC_PMIC is bool (note this driver also
> has module based initialization even when bool).
Yes, there's copy and paste going on even in kernel development.
> I am guessing because
> of some tricky module load order dependencies. If ever that becomes a
> module, this can mostly be unchanged to be loaded as a module.
You put in a macro, or any other bit of code, when it's needed, not
beforehand, "just in case". That's silly.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-06-18 18:42 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 13:59 [PATCH 0/8] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar
2015-04-29 13:59 ` Shobhit Kumar
2015-04-29 13:59 ` [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar
2015-05-05 9:32 ` [PATCH 1/8] gpiolib: " Shobhit Kumar
2015-05-05 9:32 ` Shobhit Kumar
2015-05-05 10:45 ` Lee Jones
2015-05-05 10:45 ` Lee Jones
2015-05-05 15:44 ` [Intel-gfx] " Daniel Vetter
2015-05-05 15:44 ` Daniel Vetter
2015-05-07 7:25 ` Lee Jones
2015-05-07 7:25 ` Lee Jones
2015-05-06 14:49 ` [PATCH 1/8] drivers/gpio/gpiolib: " Linus Walleij
2015-05-06 14:49 ` Linus Walleij
2015-05-06 15:09 ` [Intel-gfx] " Daniel Vetter
2015-05-06 15:09 ` Daniel Vetter
2015-05-12 8:52 ` [Intel-gfx] " Linus Walleij
2015-05-12 8:52 ` Linus Walleij
2015-04-29 13:59 ` [PATCH 2/8] drivers/pwm/core: Add support to remove registered consumer lookup tables Shobhit Kumar
2015-05-05 9:34 ` [PATCH 2/8] pwm: core: " Shobhit Kumar
2015-05-05 9:34 ` Shobhit Kumar
2015-05-06 12:21 ` Thierry Reding
2015-05-06 12:21 ` Thierry Reding
2015-04-29 14:00 ` [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Shobhit Kumar
2015-04-29 14:27 ` Lee Jones
2015-04-30 7:17 ` Shobhit Kumar
2015-04-29 14:29 ` Lee Jones
2015-04-29 14:29 ` Lee Jones
2015-05-05 9:36 ` [PATCH 3/8] mfd: intel_soc_pmic_core: " Shobhit Kumar
2015-05-12 9:14 ` Linus Walleij
2015-05-12 9:14 ` Linus Walleij
2015-05-06 14:51 ` [PATCH 3/8] drivers/mfd: " Linus Walleij
2015-05-06 14:51 ` Linus Walleij
2015-04-29 14:00 ` [PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC Shobhit Kumar
2015-04-29 14:00 ` Shobhit Kumar
2015-04-29 14:25 ` Lee Jones
2015-04-29 14:25 ` Lee Jones
2015-05-05 9:36 ` [PATCH 4/8] mfd: intel_soc_pmic_crc: " Shobhit Kumar
2015-04-29 14:00 ` [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar
2015-04-29 14:00 ` Shobhit Kumar
2015-04-29 14:24 ` Lee Jones
2015-05-05 9:48 ` Shobhit Kumar
2015-05-05 10:42 ` Lee Jones
2015-05-05 10:42 ` Lee Jones
2015-05-05 9:38 ` [PATCH 5/8] mfd: intel_soc_pmic_core: " Shobhit Kumar
2015-05-05 9:38 ` Shobhit Kumar
2015-04-29 14:00 ` [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver Shobhit Kumar
2015-04-29 14:00 ` Shobhit Kumar
2015-04-30 21:12 ` Paul Bolle
2015-06-18 17:54 ` [Intel-gfx] " Shobhit Kumar
2015-06-18 18:41 ` Paul Bolle [this message]
2015-06-19 6:46 ` Shobhit Kumar
2015-06-19 6:46 ` Shobhit Kumar
2015-06-20 11:23 ` [Intel-gfx] " Paul Bolle
2015-06-20 11:23 ` Paul Bolle
2015-06-20 18:04 ` Paul Gortmaker
2015-06-20 18:04 ` Paul Gortmaker
2015-06-22 7:55 ` Shobhit Kumar
2015-06-22 7:55 ` Shobhit Kumar
2015-05-05 9:38 ` [PATCH 6/8] pwm: crc: " Shobhit Kumar
2015-05-05 9:38 ` Shobhit Kumar
2015-05-06 7:40 ` Paul Bolle
2015-05-06 7:40 ` Paul Bolle
2015-05-07 7:13 ` [Intel-gfx] " Shobhit Kumar
2015-05-06 12:14 ` Thierry Reding
2015-05-07 7:19 ` [Intel-gfx] " Shobhit Kumar
2015-05-20 15:09 ` Shobhit Kumar
2015-06-17 2:43 ` Shobhit Kumar
2015-04-29 14:00 ` [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar
2015-04-29 14:00 ` Shobhit Kumar
2015-05-06 13:11 ` Jani Nikula
2015-05-06 13:11 ` Jani Nikula
2015-05-06 14:08 ` [Intel-gfx] " Daniel Vetter
2015-05-06 14:08 ` Daniel Vetter
2015-05-12 11:10 ` Linus Walleij
2015-04-29 14:00 ` [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar
2015-04-29 14:00 ` Shobhit Kumar
2015-05-01 2:03 ` shuang.he
2015-05-06 13:39 ` Jani Nikula
2015-05-06 13:39 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434652916.2385.124.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=airlied@linux.ie \
--cc=cwhuang@android-x86.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kumar@shobhit.info \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shobhit.kumar@intel.com \
--cc=thierry.reding@gmail.com \
--cc=wdmonster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.