From: Lee Jones <lee.jones@linaro.org> To: Shobhit Kumar <shobhit.kumar@linux.intel.com> Cc: Shobhit Kumar <shobhit.kumar@intel.com>, linux-pwm <linux-pwm@vger.kernel.org>, Jani Nikula <jani.nikula@intel.com>, Samuel Ortiz <sameo@linux.intel.com>, Alexandre Courbot <gnurou@gmail.com>, Povilas Staniulis <wdmonster@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-gpio <linux-gpio@vger.kernel.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Date: Tue, 5 May 2015 11:42:17 +0100 [thread overview] Message-ID: <20150505104217.GY4047@x1> (raw) In-Reply-To: <554891EA.7050906@linux.intel.com> On Tue, 05 May 2015, Shobhit Kumar wrote: > On 04/29/2015 07:54 PM, Lee Jones wrote: > > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > > > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >> entry for the same to be used by the consumer (Intel GFX) > >> > >> v2: Remove the lookup table on driver unload (Thierry) > >> > >> CC: Samuel Ortiz <sameo@linux.intel.com> > >> Cc: Linus Walleij <linus.walleij@linaro.org> > >> Cc: Alexandre Courbot <gnurou@gmail.com> > >> Cc: Thierry Reding <thierry.reding@gmail.com> > >> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > >> --- > >> drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > > > > How do you expect this set to be managed? > > There are some dependencies on the look up table remove functionality in > earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 > can go only after 2/8. Rest all can be independent. Taking patches 'in order' is tough to coordinate and takes a very long time. The best thing to do is have all of the patches taken in via a single tree at the same time. > > Acked-by: Lee Jones <lee.jones@linaro.org> > > > >> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > >> index f3d918e..a00ddd9 100644 > >> --- a/drivers/mfd/intel_soc_pmic_core.c > >> +++ b/drivers/mfd/intel_soc_pmic_core.c > >> @@ -25,6 +25,7 @@ > >> #include <linux/regmap.h> > >> #include <linux/mfd/intel_soc_pmic.h> > >> #include <linux/gpio/machine.h> > >> +#include <linux/pwm.h> > >> #include "intel_soc_pmic_core.h" > >> > >> /* Lookup table for the Panel Enable/Disable line as GPIO signals */ > >> @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { > >> }, > >> }; > >> > >> +/* PWM consumed by the Intel GFX */ > >> +static struct pwm_lookup crc_pwm_lookup[] = { > >> + PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL), > >> +}; > >> + > >> static int intel_soc_pmic_find_gpio_irq(struct device *dev) > >> { > >> struct gpio_desc *desc; > >> @@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > >> /* Add lookup table binding for Panel Control to the GPIO Chip */ > >> gpiod_add_lookup_table(&panel_gpio_table); > >> > >> + /* Add lookup table for crc-pwm */ > >> + pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> ret = mfd_add_devices(dev, -1, config->cell_dev, > >> config->n_cell_devs, NULL, 0, > >> regmap_irq_get_domain(pmic->irq_chip_data)); > >> @@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) > >> /* Remove lookup table for Panel Control from the GPIO Chip */ > >> gpiod_remove_lookup_table(&panel_gpio_table); > >> > >> + /* remove crc-pwm lookup table */ > >> + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> mfd_remove_devices(&i2c->dev); > >> > >> return 0; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Shobhit Kumar <shobhit.kumar@linux.intel.com> Cc: Alexandre Courbot <gnurou@gmail.com>, Samuel Ortiz <sameo@linux.intel.com>, linux-pwm <linux-pwm@vger.kernel.org>, Jani Nikula <jani.nikula@intel.com>, Shobhit Kumar <shobhit.kumar@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Povilas Staniulis <wdmonster@gmail.com>, linux-gpio <linux-gpio@vger.kernel.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Date: Tue, 5 May 2015 11:42:17 +0100 [thread overview] Message-ID: <20150505104217.GY4047@x1> (raw) In-Reply-To: <554891EA.7050906@linux.intel.com> On Tue, 05 May 2015, Shobhit Kumar wrote: > On 04/29/2015 07:54 PM, Lee Jones wrote: > > On Wed, 29 Apr 2015, Shobhit Kumar wrote: > > > >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >> entry for the same to be used by the consumer (Intel GFX) > >> > >> v2: Remove the lookup table on driver unload (Thierry) > >> > >> CC: Samuel Ortiz <sameo@linux.intel.com> > >> Cc: Linus Walleij <linus.walleij@linaro.org> > >> Cc: Alexandre Courbot <gnurou@gmail.com> > >> Cc: Thierry Reding <thierry.reding@gmail.com> > >> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > >> --- > >> drivers/mfd/intel_soc_pmic_core.c | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > > > > How do you expect this set to be managed? > > There are some dependencies on the look up table remove functionality in > earlier patches, so I think 3/8 can go in only after 1/8. Similarly 5/8 > can go only after 2/8. Rest all can be independent. Taking patches 'in order' is tough to coordinate and takes a very long time. The best thing to do is have all of the patches taken in via a single tree at the same time. > > Acked-by: Lee Jones <lee.jones@linaro.org> > > > >> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > >> index f3d918e..a00ddd9 100644 > >> --- a/drivers/mfd/intel_soc_pmic_core.c > >> +++ b/drivers/mfd/intel_soc_pmic_core.c > >> @@ -25,6 +25,7 @@ > >> #include <linux/regmap.h> > >> #include <linux/mfd/intel_soc_pmic.h> > >> #include <linux/gpio/machine.h> > >> +#include <linux/pwm.h> > >> #include "intel_soc_pmic_core.h" > >> > >> /* Lookup table for the Panel Enable/Disable line as GPIO signals */ > >> @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { > >> }, > >> }; > >> > >> +/* PWM consumed by the Intel GFX */ > >> +static struct pwm_lookup crc_pwm_lookup[] = { > >> + PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL), > >> +}; > >> + > >> static int intel_soc_pmic_find_gpio_irq(struct device *dev) > >> { > >> struct gpio_desc *desc; > >> @@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > >> /* Add lookup table binding for Panel Control to the GPIO Chip */ > >> gpiod_add_lookup_table(&panel_gpio_table); > >> > >> + /* Add lookup table for crc-pwm */ > >> + pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> ret = mfd_add_devices(dev, -1, config->cell_dev, > >> config->n_cell_devs, NULL, 0, > >> regmap_irq_get_domain(pmic->irq_chip_data)); > >> @@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) > >> /* Remove lookup table for Panel Control from the GPIO Chip */ > >> gpiod_remove_lookup_table(&panel_gpio_table); > >> > >> + /* remove crc-pwm lookup table */ > >> + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); > >> + > >> mfd_remove_devices(&i2c->dev); > >> > >> return 0; > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-05 10:42 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-29 13:59 [PATCH 0/8] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar 2015-04-29 13:59 ` Shobhit Kumar 2015-04-29 13:59 ` [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar 2015-05-05 9:32 ` [PATCH 1/8] gpiolib: " Shobhit Kumar 2015-05-05 9:32 ` Shobhit Kumar 2015-05-05 10:45 ` Lee Jones 2015-05-05 10:45 ` Lee Jones 2015-05-05 15:44 ` [Intel-gfx] " Daniel Vetter 2015-05-05 15:44 ` Daniel Vetter 2015-05-07 7:25 ` Lee Jones 2015-05-07 7:25 ` Lee Jones 2015-05-06 14:49 ` [PATCH 1/8] drivers/gpio/gpiolib: " Linus Walleij 2015-05-06 14:49 ` Linus Walleij 2015-05-06 15:09 ` [Intel-gfx] " Daniel Vetter 2015-05-06 15:09 ` Daniel Vetter 2015-05-12 8:52 ` [Intel-gfx] " Linus Walleij 2015-05-12 8:52 ` Linus Walleij 2015-04-29 13:59 ` [PATCH 2/8] drivers/pwm/core: Add support to remove registered consumer lookup tables Shobhit Kumar 2015-05-05 9:34 ` [PATCH 2/8] pwm: core: " Shobhit Kumar 2015-05-05 9:34 ` Shobhit Kumar 2015-05-06 12:21 ` Thierry Reding 2015-05-06 12:21 ` Thierry Reding 2015-04-29 14:00 ` [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Shobhit Kumar 2015-04-29 14:27 ` Lee Jones 2015-04-30 7:17 ` Shobhit Kumar 2015-04-29 14:29 ` Lee Jones 2015-04-29 14:29 ` Lee Jones 2015-05-05 9:36 ` [PATCH 3/8] mfd: intel_soc_pmic_core: " Shobhit Kumar 2015-05-12 9:14 ` Linus Walleij 2015-05-12 9:14 ` Linus Walleij 2015-05-06 14:51 ` [PATCH 3/8] drivers/mfd: " Linus Walleij 2015-05-06 14:51 ` Linus Walleij 2015-04-29 14:00 ` [PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-29 14:25 ` Lee Jones 2015-04-29 14:25 ` Lee Jones 2015-05-05 9:36 ` [PATCH 4/8] mfd: intel_soc_pmic_crc: " Shobhit Kumar 2015-04-29 14:00 ` [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-29 14:24 ` Lee Jones 2015-05-05 9:48 ` Shobhit Kumar 2015-05-05 10:42 ` Lee Jones [this message] 2015-05-05 10:42 ` Lee Jones 2015-05-05 9:38 ` [PATCH 5/8] mfd: intel_soc_pmic_core: " Shobhit Kumar 2015-05-05 9:38 ` Shobhit Kumar 2015-04-29 14:00 ` [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-30 21:12 ` Paul Bolle 2015-06-18 17:54 ` [Intel-gfx] " Shobhit Kumar 2015-06-18 18:41 ` Paul Bolle 2015-06-19 6:46 ` Shobhit Kumar 2015-06-19 6:46 ` Shobhit Kumar 2015-06-20 11:23 ` [Intel-gfx] " Paul Bolle 2015-06-20 11:23 ` Paul Bolle 2015-06-20 18:04 ` Paul Gortmaker 2015-06-20 18:04 ` Paul Gortmaker 2015-06-22 7:55 ` Shobhit Kumar 2015-06-22 7:55 ` Shobhit Kumar 2015-05-05 9:38 ` [PATCH 6/8] pwm: crc: " Shobhit Kumar 2015-05-05 9:38 ` Shobhit Kumar 2015-05-06 7:40 ` Paul Bolle 2015-05-06 7:40 ` Paul Bolle 2015-05-07 7:13 ` [Intel-gfx] " Shobhit Kumar 2015-05-06 12:14 ` Thierry Reding 2015-05-07 7:19 ` [Intel-gfx] " Shobhit Kumar 2015-05-20 15:09 ` Shobhit Kumar 2015-06-17 2:43 ` Shobhit Kumar 2015-04-29 14:00 ` [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-05-06 13:11 ` Jani Nikula 2015-05-06 13:11 ` Jani Nikula 2015-05-06 14:08 ` [Intel-gfx] " Daniel Vetter 2015-05-06 14:08 ` Daniel Vetter 2015-05-12 11:10 ` Linus Walleij 2015-04-29 14:00 ` [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-05-01 2:03 ` shuang.he 2015-05-06 13:39 ` Jani Nikula 2015-05-06 13:39 ` Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150505104217.GY4047@x1 \ --to=lee.jones@linaro.org \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gnurou@gmail.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=sameo@linux.intel.com \ --cc=shobhit.kumar@intel.com \ --cc=shobhit.kumar@linux.intel.com \ --cc=wdmonster@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.