From: Lee Jones <lee.jones@linaro.org> To: Shobhit Kumar <shobhit.kumar@intel.com>, linux-pwm <linux-pwm@vger.kernel.org>, Jani Nikula <jani.nikula@intel.com>, Samuel Ortiz <sameo@linux.intel.com>, Alexandre Courbot <gnurou@gmail.com>, David Airlie <airlied@linux.ie>, Povilas Staniulis <wdmonster@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-gpio <linux-gpio@vger.kernel.org>, Chih-Wei Huang <cwhuang@android-x86.org>, Thierry Reding <thierry.reding@gmail.com>, Daniel Vetter <daniel.vetter@intel.com>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [Intel-gfx] [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Date: Thu, 7 May 2015 08:25:03 +0100 [thread overview] Message-ID: <20150507072503.GC3400@x1> (raw) In-Reply-To: <20150505154459.GC30184@phenom.ffwll.local> On Tue, 05 May 2015, Daniel Vetter wrote: > On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote: > > This is not how we submit subsequent patch-sets. > > It is unfortunately how we handle patches on dri-devel&intel-gfx to be > able to cope with massive mail load. If everyone who submits to intel-gfx > would always resend the entire series for minor updates of som patches > we'd completely drown in the resulting flood. For one or two simple fix-ups in the set perhaps, but when submitting the entire set it needs to be threaded as a separate block, rather than seeing current and superseded patches inter-woven. This submission is already a rat's nest and I'm struggling to see which patches are which. I'm really not looking forward to v3 and v4! Attaching one version to another is a good way to keep control if you really are over-whelmed. For your use-case I would expect to see the following, which is achieved using --in-reply-to: [PATCH 0/2] Here is what I did... [PATCH 1/2] Clean up and tests [PATCH 2/2] Implementation [PATCH v2 0/3] Here is a reroll [PATCH v2 1/3] Clean up [PATCH v2 2/3] New tests [PATCH v2 3/3] Implementation The version numbers also need to be present and aren't in this re-submission. > > Please submit them as a whole, seperately from the first submission > > and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > > > > > In case we unload and load a driver module again that is registering a > > > lookup table, without this it will result in multiple entries. Provide > > > an option to remove the lookup table on driver unload > > > > > > v2: Ccing maintainers > > > v3: Correct the subject line (Lee jones) > > > > Change logs should go underneth the '---' and above the diffstat found > > below. > > Again just style differences between subsystems, I generally want to have > those above the ---. For all commits? Then I'm guessing your Git history is all but unreadable. In the kernel, unless the changelog holds valuable historic information which influance key design decisions, we put the patch changelog *below* the '---'. Please read Documentation/SubmittingPatches: "14) The canonical patch format [...] The "---" marker line serves the essential purpose of marking for patch handling tools where the changelog message ends. [...] Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be *"patch changelogs"* which describe what has changed between the v1 and v2 version of the patch." > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> > > > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > > --- > > > drivers/gpio/gpiolib.c | 13 +++++++++++++ > > > include/linux/gpio/machine.h | 1 + > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > > index 59eaa23..2420af9 100644 > > > --- a/drivers/gpio/gpiolib.c > > > +++ b/drivers/gpio/gpiolib.c > > > @@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > > > mutex_unlock(&gpio_lookup_lock); > > > } > > > > > > +/** > > > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > > > + * @table: table of consumers to unregister > > > + */ > > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > > > +{ > > > + mutex_lock(&gpio_lookup_lock); > > > + > > > + list_del(&table->list); > > > + > > > + mutex_unlock(&gpio_lookup_lock); > > > +} > > > + > > > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > > > unsigned int idx, > > > enum gpio_lookup_flags *flags) > > > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > > > index e270614..c0d712d 100644 > > > --- a/include/linux/gpio/machine.h > > > +++ b/include/linux/gpio/machine.h > > > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > > > } > > > > > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > > > > > #endif /* __LINUX_GPIO_MACHINE_H */ > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Shobhit Kumar <shobhit.kumar@intel.com>, linux-pwm <linux-pwm@vger.kernel.org>, Jani Nikula <jani.nikula@intel.com>, Samuel Ortiz <sameo@linux.intel.com>, Alexandre Courbot <gnurou@gmail.com>, David Airlie <airlied@linux.ie>, Povilas Staniulis <wdmonster@gmail.com>, intel-gfx <intel-gfx@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-gpio <linux-gpio@vger.kernel.org>, Chih-Wei Huang <cwhuang@android-x86.org>, Thierry Reding <thierry.reding@gmail.com>, Daniel Vetter <daniel.vetter@intel.com>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH 1/8] gpiolib: Add support for removing registered consumer lookup table Date: Thu, 7 May 2015 08:25:03 +0100 [thread overview] Message-ID: <20150507072503.GC3400@x1> (raw) In-Reply-To: <20150505154459.GC30184@phenom.ffwll.local> On Tue, 05 May 2015, Daniel Vetter wrote: > On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote: > > This is not how we submit subsequent patch-sets. > > It is unfortunately how we handle patches on dri-devel&intel-gfx to be > able to cope with massive mail load. If everyone who submits to intel-gfx > would always resend the entire series for minor updates of som patches > we'd completely drown in the resulting flood. For one or two simple fix-ups in the set perhaps, but when submitting the entire set it needs to be threaded as a separate block, rather than seeing current and superseded patches inter-woven. This submission is already a rat's nest and I'm struggling to see which patches are which. I'm really not looking forward to v3 and v4! Attaching one version to another is a good way to keep control if you really are over-whelmed. For your use-case I would expect to see the following, which is achieved using --in-reply-to: [PATCH 0/2] Here is what I did... [PATCH 1/2] Clean up and tests [PATCH 2/2] Implementation [PATCH v2 0/3] Here is a reroll [PATCH v2 1/3] Clean up [PATCH v2 2/3] New tests [PATCH v2 3/3] Implementation The version numbers also need to be present and aren't in this re-submission. > > Please submit them as a whole, seperately from the first submission > > and with versioning information i.e. [PATCH v2 X/Y] Stuff ... > > > > > In case we unload and load a driver module again that is registering a > > > lookup table, without this it will result in multiple entries. Provide > > > an option to remove the lookup table on driver unload > > > > > > v2: Ccing maintainers > > > v3: Correct the subject line (Lee jones) > > > > Change logs should go underneth the '---' and above the diffstat found > > below. > > Again just style differences between subsystems, I generally want to have > those above the ---. For all commits? Then I'm guessing your Git history is all but unreadable. In the kernel, unless the changelog holds valuable historic information which influance key design decisions, we put the patch changelog *below* the '---'. Please read Documentation/SubmittingPatches: "14) The canonical patch format [...] The "---" marker line serves the essential purpose of marking for patch handling tools where the changelog message ends. [...] Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be *"patch changelogs"* which describe what has changed between the v1 and v2 version of the patch." > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> > > > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > > --- > > > drivers/gpio/gpiolib.c | 13 +++++++++++++ > > > include/linux/gpio/machine.h | 1 + > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > > index 59eaa23..2420af9 100644 > > > --- a/drivers/gpio/gpiolib.c > > > +++ b/drivers/gpio/gpiolib.c > > > @@ -1658,6 +1658,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > > > mutex_unlock(&gpio_lookup_lock); > > > } > > > > > > +/** > > > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > > > + * @table: table of consumers to unregister > > > + */ > > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > > > +{ > > > + mutex_lock(&gpio_lookup_lock); > > > + > > > + list_del(&table->list); > > > + > > > + mutex_unlock(&gpio_lookup_lock); > > > +} > > > + > > > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > > > unsigned int idx, > > > enum gpio_lookup_flags *flags) > > > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > > > index e270614..c0d712d 100644 > > > --- a/include/linux/gpio/machine.h > > > +++ b/include/linux/gpio/machine.h > > > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > > > } > > > > > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > > > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > > > > > #endif /* __LINUX_GPIO_MACHINE_H */ > > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-05-07 7:25 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-29 13:59 [PATCH 0/8] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar 2015-04-29 13:59 ` Shobhit Kumar 2015-04-29 13:59 ` [PATCH 1/8] drivers/gpio/gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar 2015-05-05 9:32 ` [PATCH 1/8] gpiolib: " Shobhit Kumar 2015-05-05 9:32 ` Shobhit Kumar 2015-05-05 10:45 ` Lee Jones 2015-05-05 10:45 ` Lee Jones 2015-05-05 15:44 ` [Intel-gfx] " Daniel Vetter 2015-05-05 15:44 ` Daniel Vetter 2015-05-07 7:25 ` Lee Jones [this message] 2015-05-07 7:25 ` Lee Jones 2015-05-06 14:49 ` [PATCH 1/8] drivers/gpio/gpiolib: " Linus Walleij 2015-05-06 14:49 ` Linus Walleij 2015-05-06 15:09 ` [Intel-gfx] " Daniel Vetter 2015-05-06 15:09 ` Daniel Vetter 2015-05-12 8:52 ` [Intel-gfx] " Linus Walleij 2015-05-12 8:52 ` Linus Walleij 2015-04-29 13:59 ` [PATCH 2/8] drivers/pwm/core: Add support to remove registered consumer lookup tables Shobhit Kumar 2015-05-05 9:34 ` [PATCH 2/8] pwm: core: " Shobhit Kumar 2015-05-05 9:34 ` Shobhit Kumar 2015-05-06 12:21 ` Thierry Reding 2015-05-06 12:21 ` Thierry Reding 2015-04-29 14:00 ` [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Shobhit Kumar 2015-04-29 14:27 ` Lee Jones 2015-04-30 7:17 ` Shobhit Kumar 2015-04-29 14:29 ` Lee Jones 2015-04-29 14:29 ` Lee Jones 2015-05-05 9:36 ` [PATCH 3/8] mfd: intel_soc_pmic_core: " Shobhit Kumar 2015-05-12 9:14 ` Linus Walleij 2015-05-12 9:14 ` Linus Walleij 2015-05-06 14:51 ` [PATCH 3/8] drivers/mfd: " Linus Walleij 2015-05-06 14:51 ` Linus Walleij 2015-04-29 14:00 ` [PATCH 4/8] drivers/mfd: Add PWM cell device for Crystalcove PMIC Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-29 14:25 ` Lee Jones 2015-04-29 14:25 ` Lee Jones 2015-05-05 9:36 ` [PATCH 4/8] mfd: intel_soc_pmic_crc: " Shobhit Kumar 2015-04-29 14:00 ` [PATCH 5/8] drivers/mfd: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-29 14:24 ` Lee Jones 2015-05-05 9:48 ` Shobhit Kumar 2015-05-05 10:42 ` Lee Jones 2015-05-05 10:42 ` Lee Jones 2015-05-05 9:38 ` [PATCH 5/8] mfd: intel_soc_pmic_core: " Shobhit Kumar 2015-05-05 9:38 ` Shobhit Kumar 2015-04-29 14:00 ` [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-04-30 21:12 ` Paul Bolle 2015-06-18 17:54 ` [Intel-gfx] " Shobhit Kumar 2015-06-18 18:41 ` Paul Bolle 2015-06-19 6:46 ` Shobhit Kumar 2015-06-19 6:46 ` Shobhit Kumar 2015-06-20 11:23 ` [Intel-gfx] " Paul Bolle 2015-06-20 11:23 ` Paul Bolle 2015-06-20 18:04 ` Paul Gortmaker 2015-06-20 18:04 ` Paul Gortmaker 2015-06-22 7:55 ` Shobhit Kumar 2015-06-22 7:55 ` Shobhit Kumar 2015-05-05 9:38 ` [PATCH 6/8] pwm: crc: " Shobhit Kumar 2015-05-05 9:38 ` Shobhit Kumar 2015-05-06 7:40 ` Paul Bolle 2015-05-06 7:40 ` Paul Bolle 2015-05-07 7:13 ` [Intel-gfx] " Shobhit Kumar 2015-05-06 12:14 ` Thierry Reding 2015-05-07 7:19 ` [Intel-gfx] " Shobhit Kumar 2015-05-20 15:09 ` Shobhit Kumar 2015-06-17 2:43 ` Shobhit Kumar 2015-04-29 14:00 ` [PATCH 7/8] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-05-06 13:11 ` Jani Nikula 2015-05-06 13:11 ` Jani Nikula 2015-05-06 14:08 ` [Intel-gfx] " Daniel Vetter 2015-05-06 14:08 ` Daniel Vetter 2015-05-12 11:10 ` Linus Walleij 2015-04-29 14:00 ` [PATCH 8/8] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar 2015-04-29 14:00 ` Shobhit Kumar 2015-05-01 2:03 ` shuang.he 2015-05-06 13:39 ` Jani Nikula 2015-05-06 13:39 ` Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150507072503.GC3400@x1 \ --to=lee.jones@linaro.org \ --cc=airlied@linux.ie \ --cc=cwhuang@android-x86.org \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=gnurou@gmail.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=sameo@linux.intel.com \ --cc=shobhit.kumar@intel.com \ --cc=thierry.reding@gmail.com \ --cc=wdmonster@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.