* [Qemu-devel] [PATCH] vnc: fix vnc client authentication
@ 2015-07-14 12:51 Wolfgang Bumiller
2015-07-17 10:51 ` Daniel P. Berrange
0 siblings, 1 reply; 2+ messages in thread
From: Wolfgang Bumiller @ 2015-07-14 12:51 UTC (permalink / raw)
To: qemu-devel
Commit 800567a61 updated the code to the generic crypto API
and mixed up encrypt and decrypt functions in
procotol_client_auth_vnc.
(Used to be: deskey(key, EN0) which encrypts, and was
changed to qcrypto_cipher_decrypt in 800567a61.)
Changed it to qcrypto_cipher_encrypt now.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
---
ui/vnc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 94e4f19..1483958 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
goto reject;
}
- if (qcrypto_cipher_decrypt(cipher,
+ if (qcrypto_cipher_encrypt(cipher,
vs->challenge,
response,
VNC_AUTH_CHALLENGE_SIZE,
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: fix vnc client authentication
2015-07-14 12:51 [Qemu-devel] [PATCH] vnc: fix vnc client authentication Wolfgang Bumiller
@ 2015-07-17 10:51 ` Daniel P. Berrange
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrange @ 2015-07-17 10:51 UTC (permalink / raw)
To: Wolfgang Bumiller; +Cc: qemu-devel
On Tue, Jul 14, 2015 at 02:51:40PM +0200, Wolfgang Bumiller wrote:
> Commit 800567a61 updated the code to the generic crypto API
> and mixed up encrypt and decrypt functions in
> procotol_client_auth_vnc.
> (Used to be: deskey(key, EN0) which encrypts, and was
> changed to qcrypto_cipher_decrypt in 800567a61.)
> Changed it to qcrypto_cipher_encrypt now.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> ui/vnc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 94e4f19..1483958 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
> goto reject;
> }
>
> - if (qcrypto_cipher_decrypt(cipher,
> + if (qcrypto_cipher_encrypt(cipher,
> vs->challenge,
> response,
> VNC_AUTH_CHALLENGE_SIZE,
I see its already merged while i was on holiday, but none the
less
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Thanks for fixing my stupid typo.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-17 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-14 12:51 [Qemu-devel] [PATCH] vnc: fix vnc client authentication Wolfgang Bumiller
2015-07-17 10:51 ` Daniel P. Berrange
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.