From: Eric Dumazet <eric.dumazet@gmail.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net-next 1/2] net: Set sk_txhash from a random number
Date: Wed, 29 Jul 2015 12:06:48 +0200 [thread overview]
Message-ID: <1438164408.20182.86.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20150729095416.GC13113@pox.localdomain>
On Wed, 2015-07-29 at 11:54 +0200, Thomas Graf wrote:
> skb_set_hash_from_sk()
> skb_get_hash()
>
> Am I misreading this? I'm not using SO_REUSEPORT and it might be OK
> to assume that different sockets may go to different queues even if
> the L4 tuple is identical.
skb_set_hash_from_sk() sets skb->hash in output path. Nothing uses it
then later. bonding uses its own hash functions.
SO_REUSEPORT is on input path, and uses its own hash anyway.
next prev parent reply other threads:[~2015-07-29 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 23:02 [PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs Tom Herbert
2015-07-28 23:02 ` [PATCH net-next 1/2] net: Set sk_txhash from a random number Tom Herbert
2015-07-29 9:13 ` Thomas Graf
2015-07-29 9:29 ` Eric Dumazet
2015-07-29 9:54 ` Thomas Graf
2015-07-29 10:06 ` Eric Dumazet [this message]
2015-07-29 10:47 ` Thomas Graf
2015-07-29 15:58 ` Tom Herbert
2015-07-29 20:02 ` Thomas Graf
2015-12-08 8:33 ` [net-next,1/2] " Alexander Drozdov
2015-12-08 13:15 ` Eric Dumazet
2015-12-08 16:33 ` Tom Herbert
2015-12-09 11:14 ` Alexander Drozdov
2015-07-28 23:02 ` [PATCH net-next 2/2] net: Recompute sk_txhash on negative routing advice Tom Herbert
2015-07-30 5:44 ` [PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438164408.20182.86.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.