From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<devicetree@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Stephen Boyd <sboyd@codeaurora.org>,
<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-mediatek@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>, <srv_heupstream@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/5] Add SMP bringup support for mt65xx socs
Date: Fri, 7 Aug 2015 18:50:18 +0800 [thread overview]
Message-ID: <1438944618.14580.5.camel@mtksdaap41> (raw)
In-Reply-To: <20150805223115.GD7557@n2100.arm.linux.org.uk>
On Wed, 2015-08-05 at 23:31 +0100, Russell King - ARM Linux wrote:
> On Wed, Aug 05, 2015 at 08:44:11PM +0200, Matthias Brugger wrote:
> > On Tuesday, July 14, 2015 01:18:26 PM Yingjoe Chen wrote:
> > > This series add SMP brinup support for MediaTek SoCs. This is based
> > > on v4.2-rc1 and Matthias' next branch (for dts parts).
<...>
> > Applied to v4.2-next/soc-2 and v4.2-next/dts-2
>
> I've just NAK'd one of the patches in this set; I don't tend to even see
> mediatek patches normally, as they all head into my junk mailfolder
> because mediatek's mail server setup is truely abysmal (it has broken
> reverse DNS - the DNS positively says that the mail server is not a
> legit owner of the name it claims to be.)
Hi Russell,
Hope you see this.
Thanks for your review. I already pass this information to our IT, hope
they can resolve this soon.
> The problem is that this patch series uses memblock_reserve() way after
> the memory has been transitioned out of memblock's control, so actually
> this has no effect.
>
> I've seen a number of patches doing this. I'm not sure what's soo friggin
> hard for people to understand: memblock is about the EARLY stages of
> getting the system up and running. Once the memory has been handed
> over to the kernel's memory management, memblock MUST NOT BE USED to
> reserve memory.
>
> There is one place, and one place only in the ARM kernel where
> memblock_reserve() is possible, and that's in the ->reserve machine
> callback. NOWHERE ELSE is permissible.
It seems we can write memory-reserve node in device tree to do this as
well. Do you prefer us to reserve memblock in reserve callback or using
device tree?
Joe.C
WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>,
srv_heupstream@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] Add SMP bringup support for mt65xx socs
Date: Fri, 7 Aug 2015 18:50:18 +0800 [thread overview]
Message-ID: <1438944618.14580.5.camel@mtksdaap41> (raw)
In-Reply-To: <20150805223115.GD7557@n2100.arm.linux.org.uk>
On Wed, 2015-08-05 at 23:31 +0100, Russell King - ARM Linux wrote:
> On Wed, Aug 05, 2015 at 08:44:11PM +0200, Matthias Brugger wrote:
> > On Tuesday, July 14, 2015 01:18:26 PM Yingjoe Chen wrote:
> > > This series add SMP brinup support for MediaTek SoCs. This is based
> > > on v4.2-rc1 and Matthias' next branch (for dts parts).
<...>
> > Applied to v4.2-next/soc-2 and v4.2-next/dts-2
>
> I've just NAK'd one of the patches in this set; I don't tend to even see
> mediatek patches normally, as they all head into my junk mailfolder
> because mediatek's mail server setup is truely abysmal (it has broken
> reverse DNS - the DNS positively says that the mail server is not a
> legit owner of the name it claims to be.)
Hi Russell,
Hope you see this.
Thanks for your review. I already pass this information to our IT, hope
they can resolve this soon.
> The problem is that this patch series uses memblock_reserve() way after
> the memory has been transitioned out of memblock's control, so actually
> this has no effect.
>
> I've seen a number of patches doing this. I'm not sure what's soo friggin
> hard for people to understand: memblock is about the EARLY stages of
> getting the system up and running. Once the memory has been handed
> over to the kernel's memory management, memblock MUST NOT BE USED to
> reserve memory.
>
> There is one place, and one place only in the ARM kernel where
> memblock_reserve() is possible, and that's in the ->reserve machine
> callback. NOWHERE ELSE is permissible.
It seems we can write memory-reserve node in device tree to do this as
well. Do you prefer us to reserve memblock in reserve callback or using
device tree?
Joe.C
WARNING: multiple messages have this Message-ID (diff)
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/5] Add SMP bringup support for mt65xx socs
Date: Fri, 7 Aug 2015 18:50:18 +0800 [thread overview]
Message-ID: <1438944618.14580.5.camel@mtksdaap41> (raw)
In-Reply-To: <20150805223115.GD7557@n2100.arm.linux.org.uk>
On Wed, 2015-08-05 at 23:31 +0100, Russell King - ARM Linux wrote:
> On Wed, Aug 05, 2015 at 08:44:11PM +0200, Matthias Brugger wrote:
> > On Tuesday, July 14, 2015 01:18:26 PM Yingjoe Chen wrote:
> > > This series add SMP brinup support for MediaTek SoCs. This is based
> > > on v4.2-rc1 and Matthias' next branch (for dts parts).
<...>
> > Applied to v4.2-next/soc-2 and v4.2-next/dts-2
>
> I've just NAK'd one of the patches in this set; I don't tend to even see
> mediatek patches normally, as they all head into my junk mailfolder
> because mediatek's mail server setup is truely abysmal (it has broken
> reverse DNS - the DNS positively says that the mail server is not a
> legit owner of the name it claims to be.)
Hi Russell,
Hope you see this.
Thanks for your review. I already pass this information to our IT, hope
they can resolve this soon.
> The problem is that this patch series uses memblock_reserve() way after
> the memory has been transitioned out of memblock's control, so actually
> this has no effect.
>
> I've seen a number of patches doing this. I'm not sure what's soo friggin
> hard for people to understand: memblock is about the EARLY stages of
> getting the system up and running. Once the memory has been handed
> over to the kernel's memory management, memblock MUST NOT BE USED to
> reserve memory.
>
> There is one place, and one place only in the ARM kernel where
> memblock_reserve() is possible, and that's in the ->reserve machine
> callback. NOWHERE ELSE is permissible.
It seems we can write memory-reserve node in device tree to do this as
well. Do you prefer us to reserve memblock in reserve callback or using
device tree?
Joe.C
next prev parent reply other threads:[~2015-08-07 10:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 5:18 [PATCH v3 0/5] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 1/5] ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 2/5] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 3/5] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-08-05 22:26 ` Russell King - ARM Linux
2015-08-05 22:26 ` Russell King - ARM Linux
2015-08-05 22:26 ` Russell King - ARM Linux
2015-07-14 5:18 ` [PATCH v3 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 14:19 ` Nathan Lynch
2015-07-14 14:19 ` Nathan Lynch
2015-07-14 14:19 ` Nathan Lynch
2015-07-16 14:44 ` Yingjoe Chen
2015-07-16 14:44 ` Yingjoe Chen
2015-07-16 14:44 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 5/5] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-08-05 18:44 ` [PATCH v3 0/5] Add SMP bringup support for mt65xx socs Matthias Brugger
2015-08-05 18:44 ` Matthias Brugger
2015-08-05 18:44 ` Matthias Brugger
2015-08-05 22:31 ` Russell King - ARM Linux
2015-08-05 22:31 ` Russell King - ARM Linux
2015-08-07 10:50 ` Yingjoe Chen [this message]
2015-08-07 10:50 ` Yingjoe Chen
2015-08-07 10:50 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-08-07 17:13 ` Matthias Brugger
2015-08-07 17:13 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438944618.14580.5.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.