From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>,
srv_heupstream@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/5] ARM: mediatek: add smp bringup code
Date: Wed, 5 Aug 2015 23:26:46 +0100 [thread overview]
Message-ID: <20150805222646.GA4699@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1436851111-2369-4-git-send-email-yingjoe.chen@mediatek.com>
On Tue, Jul 14, 2015 at 01:18:29PM +0800, Yingjoe Chen wrote:
> +static void __init __mtk_smp_prepare_cpus(unsigned int max_cpus, int trustzone)
> +{
> + int i, num;
> + const struct of_device_id *infos;
> +
> + if (trustzone) {
> + num = ARRAY_SIZE(mtk_tz_smp_boot_infos);
> + infos = mtk_tz_smp_boot_infos;
> + } else {
> + num = ARRAY_SIZE(mtk_smp_boot_infos);
> + infos = mtk_smp_boot_infos;
> + }
> +
> + /* Find smp boot info for this SoC */
> + for (i = 0; i < num; i++) {
> + if (of_machine_is_compatible(infos[i].compatible)) {
> + mtk_smp_info = infos[i].data;
> + break;
> + }
> + }
> +
> + if (!mtk_smp_info) {
> + pr_err("%s: Device is not supported\n", __func__);
> + return;
> + }
> +
> + if (trustzone) {
> + if (memblock_reserve(mtk_smp_info->smp_base, MTK_SMP_REG_SIZE)) {
Strong NAK.
This is _FAR_ too late to be calling memblock_reserve(). You won't be
reserving memory as you think you are (it's already handed over to the
kernel's allocators by this stage.)
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 3/5] ARM: mediatek: add smp bringup code
Date: Wed, 5 Aug 2015 23:26:46 +0100 [thread overview]
Message-ID: <20150805222646.GA4699@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1436851111-2369-4-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Tue, Jul 14, 2015 at 01:18:29PM +0800, Yingjoe Chen wrote:
> +static void __init __mtk_smp_prepare_cpus(unsigned int max_cpus, int trustzone)
> +{
> + int i, num;
> + const struct of_device_id *infos;
> +
> + if (trustzone) {
> + num = ARRAY_SIZE(mtk_tz_smp_boot_infos);
> + infos = mtk_tz_smp_boot_infos;
> + } else {
> + num = ARRAY_SIZE(mtk_smp_boot_infos);
> + infos = mtk_smp_boot_infos;
> + }
> +
> + /* Find smp boot info for this SoC */
> + for (i = 0; i < num; i++) {
> + if (of_machine_is_compatible(infos[i].compatible)) {
> + mtk_smp_info = infos[i].data;
> + break;
> + }
> + }
> +
> + if (!mtk_smp_info) {
> + pr_err("%s: Device is not supported\n", __func__);
> + return;
> + }
> +
> + if (trustzone) {
> + if (memblock_reserve(mtk_smp_info->smp_base, MTK_SMP_REG_SIZE)) {
Strong NAK.
This is _FAR_ too late to be calling memblock_reserve(). You won't be
reserving memory as you think you are (it's already handed over to the
kernel's allocators by this stage.)
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] ARM: mediatek: add smp bringup code
Date: Wed, 5 Aug 2015 23:26:46 +0100 [thread overview]
Message-ID: <20150805222646.GA4699@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1436851111-2369-4-git-send-email-yingjoe.chen@mediatek.com>
On Tue, Jul 14, 2015 at 01:18:29PM +0800, Yingjoe Chen wrote:
> +static void __init __mtk_smp_prepare_cpus(unsigned int max_cpus, int trustzone)
> +{
> + int i, num;
> + const struct of_device_id *infos;
> +
> + if (trustzone) {
> + num = ARRAY_SIZE(mtk_tz_smp_boot_infos);
> + infos = mtk_tz_smp_boot_infos;
> + } else {
> + num = ARRAY_SIZE(mtk_smp_boot_infos);
> + infos = mtk_smp_boot_infos;
> + }
> +
> + /* Find smp boot info for this SoC */
> + for (i = 0; i < num; i++) {
> + if (of_machine_is_compatible(infos[i].compatible)) {
> + mtk_smp_info = infos[i].data;
> + break;
> + }
> + }
> +
> + if (!mtk_smp_info) {
> + pr_err("%s: Device is not supported\n", __func__);
> + return;
> + }
> +
> + if (trustzone) {
> + if (memblock_reserve(mtk_smp_info->smp_base, MTK_SMP_REG_SIZE)) {
Strong NAK.
This is _FAR_ too late to be calling memblock_reserve(). You won't be
reserving memory as you think you are (it's already handed over to the
kernel's allocators by this stage.)
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-08-05 22:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 5:18 [PATCH v3 0/5] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 1/5] ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 2/5] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 3/5] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-08-05 22:26 ` Russell King - ARM Linux [this message]
2015-08-05 22:26 ` Russell King - ARM Linux
2015-08-05 22:26 ` Russell King - ARM Linux
2015-07-14 5:18 ` [PATCH v3 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 14:19 ` Nathan Lynch
2015-07-14 14:19 ` Nathan Lynch
2015-07-14 14:19 ` Nathan Lynch
2015-07-16 14:44 ` Yingjoe Chen
2015-07-16 14:44 ` Yingjoe Chen
2015-07-16 14:44 ` Yingjoe Chen
2015-07-14 5:18 ` [PATCH v3 5/5] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-07-14 5:18 ` Yingjoe Chen
2015-08-05 18:44 ` [PATCH v3 0/5] Add SMP bringup support for mt65xx socs Matthias Brugger
2015-08-05 18:44 ` Matthias Brugger
2015-08-05 18:44 ` Matthias Brugger
2015-08-05 22:31 ` Russell King - ARM Linux
2015-08-05 22:31 ` Russell King - ARM Linux
2015-08-07 10:50 ` Yingjoe Chen
2015-08-07 10:50 ` Yingjoe Chen
2015-08-07 10:50 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-09-24 15:44 ` Yingjoe Chen
2015-08-07 17:13 ` Matthias Brugger
2015-08-07 17:13 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805222646.GA4699@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.