From: Julia Lawall <Julia.Lawall@lip6.fr> To: Felipe Balbi <balbi@ti.com> Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/39] usb: gadget: drop null test before destroy functions Date: Sun, 13 Sep 2015 14:15:09 +0200 [thread overview] Message-ID: <1442146532-9100-17-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/usb/gadget/udc/bdc/bdc_core.c | 3 +-- drivers/usb/gadget/udc/gr_udc.c | 3 +-- drivers/usb/gadget/udc/mv_u3d_core.c | 3 +-- drivers/usb/gadget/udc/mv_udc_core.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 339af51..81b6229 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2100,8 +2100,7 @@ static int mv_udc_remove(struct platform_device *pdev) } /* free memory allocated in probe */ - if (udc->dtd_pool) - dma_pool_destroy(udc->dtd_pool); + dma_pool_destroy(udc->dtd_pool); if (udc->ep_dqh) dma_free_coherent(&pdev->dev, udc->ep_dqh_size, diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index 8aa2593..b9429bc 100644 --- a/drivers/usb/gadget/udc/gr_udc.c +++ b/drivers/usb/gadget/udc/gr_udc.c @@ -2117,8 +2117,7 @@ static int gr_remove(struct platform_device *pdev) return -EBUSY; gr_dfs_delete(dev); - if (dev->desc_pool) - dma_pool_destroy(dev->desc_pool); + dma_pool_destroy(dev->desc_pool); platform_set_drvdata(pdev, NULL); gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req); diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index 4c48969..dafe74e 100644 --- a/drivers/usb/gadget/udc/mv_u3d_core.c +++ b/drivers/usb/gadget/udc/mv_u3d_core.c @@ -1767,8 +1767,7 @@ static int mv_u3d_remove(struct platform_device *dev) usb_del_gadget_udc(&u3d->gadget); /* free memory allocated in probe */ - if (u3d->trb_pool) - dma_pool_destroy(u3d->trb_pool); + dma_pool_destroy(u3d->trb_pool); if (u3d->ep_context) dma_free_coherent(&dev->dev, u3d->ep_context_size, diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 5c8f4ef..ccb9c21 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -324,8 +324,7 @@ static void bdc_mem_free(struct bdc *bdc) bdc->scratchpad.buff, bdc->scratchpad.sp_dma); /* Destroy the dma pools */ - if (bdc->bd_table_pool) - dma_pool_destroy(bdc->bd_table_pool); + dma_pool_destroy(bdc->bd_table_pool); /* Free the bdc_ep array */ kfree(bdc->bdc_ep_array);
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: Felipe Balbi <balbi@ti.com> Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 16/39] usb: gadget: drop null test before destroy functions Date: Sun, 13 Sep 2015 12:15:09 +0000 [thread overview] Message-ID: <1442146532-9100-17-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/usb/gadget/udc/bdc/bdc_core.c | 3 +-- drivers/usb/gadget/udc/gr_udc.c | 3 +-- drivers/usb/gadget/udc/mv_u3d_core.c | 3 +-- drivers/usb/gadget/udc/mv_udc_core.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index 339af51..81b6229 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2100,8 +2100,7 @@ static int mv_udc_remove(struct platform_device *pdev) } /* free memory allocated in probe */ - if (udc->dtd_pool) - dma_pool_destroy(udc->dtd_pool); + dma_pool_destroy(udc->dtd_pool); if (udc->ep_dqh) dma_free_coherent(&pdev->dev, udc->ep_dqh_size, diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index 8aa2593..b9429bc 100644 --- a/drivers/usb/gadget/udc/gr_udc.c +++ b/drivers/usb/gadget/udc/gr_udc.c @@ -2117,8 +2117,7 @@ static int gr_remove(struct platform_device *pdev) return -EBUSY; gr_dfs_delete(dev); - if (dev->desc_pool) - dma_pool_destroy(dev->desc_pool); + dma_pool_destroy(dev->desc_pool); platform_set_drvdata(pdev, NULL); gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req); diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index 4c48969..dafe74e 100644 --- a/drivers/usb/gadget/udc/mv_u3d_core.c +++ b/drivers/usb/gadget/udc/mv_u3d_core.c @@ -1767,8 +1767,7 @@ static int mv_u3d_remove(struct platform_device *dev) usb_del_gadget_udc(&u3d->gadget); /* free memory allocated in probe */ - if (u3d->trb_pool) - dma_pool_destroy(u3d->trb_pool); + dma_pool_destroy(u3d->trb_pool); if (u3d->ep_context) dma_free_coherent(&dev->dev, u3d->ep_context_size, diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c index 5c8f4ef..ccb9c21 100644 --- a/drivers/usb/gadget/udc/bdc/bdc_core.c +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c @@ -324,8 +324,7 @@ static void bdc_mem_free(struct bdc *bdc) bdc->scratchpad.buff, bdc->scratchpad.sp_dma); /* Destroy the dma pools */ - if (bdc->bd_table_pool) - dma_pool_destroy(bdc->bd_table_pool); + dma_pool_destroy(bdc->bd_table_pool); /* Free the bdc_ep array */ kfree(bdc->bdc_ep_array);
next prev parent reply other threads:[~2015-09-13 12:33 UTC|newest] Thread overview: 163+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-13 12:14 [PATCH 00/39] drop null test before destroy functions Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` [Cluster-devel] " Julia Lawall 2015-09-13 12:14 ` [Intel-wired-lan] " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` [PATCH 01/39] mtd: nandsim: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-22 0:07 ` Brian Norris 2015-09-22 0:07 ` Brian Norris 2015-09-13 12:14 ` [PATCH 02/39] nilfs2: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-14 3:29 ` Ryusuke Konishi 2015-09-14 3:29 ` Ryusuke Konishi 2015-09-14 3:29 ` Ryusuke Konishi 2015-09-13 12:14 ` [PATCH 03/39] firmware: google: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` [PATCH 04/39] debugobjects: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` [PATCH 05/39] xhci: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-13 12:14 ` [PATCH 06/39] Btrfs: " Julia Lawall 2015-09-13 12:14 ` Julia Lawall 2015-09-14 20:43 ` David Sterba 2015-09-14 20:43 ` David Sterba 2015-09-13 12:15 ` [PATCH 07/39] fs: ext4: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 08/39] pktcdvd: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-29 13:02 ` Jiri Kosina 2015-09-29 13:02 ` Jiri Kosina 2015-09-13 12:15 ` [PATCH 09/39] aoe: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 1:39 ` Ed Cashin 2015-09-15 1:39 ` Ed Cashin 2015-09-13 12:15 ` [PATCH 10/39] atm: he: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 23:50 ` David Miller 2015-09-15 23:50 ` David Miller 2015-09-13 12:15 ` [PATCH 11/39] hfi1: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 13:56 ` Marciniszyn, Mike 2015-09-15 13:56 ` Marciniszyn, Mike 2015-09-13 12:15 ` [PATCH 12/39] dm: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 13:46 ` [dm-devel] " Mikulas Patocka 2015-09-14 13:46 ` Mikulas Patocka 2015-09-14 14:00 ` Mike Snitzer 2015-09-14 14:00 ` Mike Snitzer 2015-09-14 14:05 ` Mikulas Patocka 2015-09-14 14:05 ` Mikulas Patocka 2015-09-14 18:50 ` Julia Lawall 2015-09-14 18:50 ` Julia Lawall 2015-09-14 14:23 ` [dm-devel] " walter harms 2015-09-14 14:23 ` walter harms 2015-09-13 12:15 ` [PATCH 13/39] staging: lustre: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 14/39] SUNRPC: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 16:07 ` J. Bruce Fields 2015-09-14 16:07 ` J. Bruce Fields 2015-09-14 16:07 ` J. Bruce Fields 2015-09-14 16:25 ` Trond Myklebust 2015-09-14 16:25 ` Trond Myklebust 2015-09-13 12:15 ` [PATCH 15/39] bcache: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 9:08 ` Johannes Thumshirn 2015-09-14 9:08 ` Johannes Thumshirn 2015-09-13 12:15 ` Julia Lawall [this message] 2015-09-13 12:15 ` [PATCH 16/39] usb: gadget: " Julia Lawall 2015-09-13 12:15 ` [PATCH 17/39] md: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 7:29 ` Neil Brown 2015-09-15 7:29 ` Neil Brown 2015-09-13 12:15 ` [PATCH 18/39] whci: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 19/39] jbd2: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 20/39] ixgbe: " Julia Lawall 2015-09-13 12:15 ` [Intel-wired-lan] " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 21/39] drbd: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 22/39] nfsd: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 16:06 ` J. Bruce Fields 2015-09-14 16:06 ` J. Bruce Fields 2015-09-13 12:15 ` [PATCH 23/39] UBI: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-10-03 18:36 ` Richard Weinberger 2015-10-03 18:36 ` Richard Weinberger 2015-09-13 12:15 ` [PATCH 24/39] dlm: " Julia Lawall 2015-09-13 12:15 ` [Cluster-devel] " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 25/39] net: core: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 23:50 ` David Miller 2015-09-15 23:50 ` David Miller 2015-09-13 12:15 ` [PATCH 26/39] dmaengine: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-21 17:10 ` Vinod Koul 2015-09-21 17:22 ` Vinod Koul 2015-09-13 12:15 ` [PATCH 27/39] ocfs2: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 28/39] ecryptfs: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 2:08 ` Tyler Hicks 2015-09-15 2:08 ` Tyler Hicks 2015-09-15 4:36 ` Julia Lawall 2015-09-15 4:36 ` Julia Lawall 2015-09-15 14:45 ` Tyler Hicks 2015-09-15 14:45 ` Tyler Hicks 2015-09-13 12:15 ` [PATCH 29/39] thunderbolt: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 30/39] block: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 31/39] KVM: MMU: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 8:30 ` Paolo Bonzini 2015-09-14 8:30 ` Paolo Bonzini 2015-09-13 12:15 ` [PATCH 32/39] drm: i915: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-30 8:44 ` [Intel-gfx] " Daniel Vetter 2015-09-30 8:44 ` Daniel Vetter 2015-09-30 8:44 ` Daniel Vetter 2015-09-13 12:15 ` [PATCH 33/39] rbd: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 9:53 ` Ilya Dryomov 2015-09-14 9:53 ` Ilya Dryomov 2015-09-13 12:15 ` [PATCH 34/39] dccp: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-15 23:50 ` David Miller 2015-09-15 23:50 ` David Miller 2015-09-15 23:50 ` David Miller 2015-09-13 12:15 ` [PATCH 35/39] GFS2: " Julia Lawall 2015-09-13 12:15 ` [Cluster-devel] " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 36/39] jffs2: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` [PATCH 37/39] f2fs crypto: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-16 10:17 ` Chao Yu 2015-09-16 10:17 ` Chao Yu 2015-09-16 10:17 ` Chao Yu 2015-09-13 12:15 ` [PATCH 38/39] iommu/amd: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-29 13:41 ` Joerg Roedel 2015-09-29 13:41 ` Joerg Roedel 2015-09-13 12:15 ` [PATCH 39/39] usb: host: " Julia Lawall 2015-09-13 12:15 ` Julia Lawall 2015-09-14 11:55 ` [PATCH 00/39] " SF Markus Elfring 2015-09-14 11:55 ` SF Markus Elfring 2015-09-14 11:55 ` [Cluster-devel] " SF Markus Elfring 2015-09-14 11:55 ` [Intel-wired-lan] " SF Markus Elfring 2015-09-14 11:55 ` SF Markus Elfring 2015-09-14 11:55 ` SF Markus Elfring 2015-09-14 11:55 ` SF Markus Elfring 2015-09-14 11:55 ` SF Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1442146532-9100-17-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=balbi@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=sergey.senozhatsky@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.