From: Johannes Thumshirn <jthumshirn@suse.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org,
Neil Brown <neilb@suse.com>,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/39] bcache: drop null test before destroy functions
Date: Mon, 14 Sep 2015 11:08:18 +0200 [thread overview]
Message-ID: <mqdfv2hnzb1.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <1442146532-9100-16-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Sun, 13 Sep 2015 14:15:08 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> ---
> drivers/md/bcache/bset.c | 3 +--
> drivers/md/bcache/request.c | 3 +--
> drivers/md/bcache/super.c | 9 +++------
> 3 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 8e9877b..bd4678c 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1145,8 +1145,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>
> void bch_request_exit(void)
> {
> - if (bch_search_cache)
> - kmem_cache_destroy(bch_search_cache);
> + kmem_cache_destroy(bch_search_cache);
> }
>
> int __init bch_request_init(void)
> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> index 646fe85..479117c 100644
> --- a/drivers/md/bcache/bset.c
> +++ b/drivers/md/bcache/bset.c
> @@ -1116,8 +1116,7 @@ struct bkey *bch_btree_iter_next_filter(struct btree_iter *iter,
>
> void bch_bset_sort_state_free(struct bset_sort_state *state)
> {
> - if (state->pool)
> - mempool_destroy(state->pool);
> + mempool_destroy(state->pool);
> }
>
> int bch_bset_sort_state_init(struct bset_sort_state *state, unsigned page_order)
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 679a093..c27a0ff 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1335,12 +1335,9 @@ static void cache_set_free(struct closure *cl)
> destroy_workqueue(c->moving_gc_wq);
> if (c->bio_split)
> bioset_free(c->bio_split);
> - if (c->fill_iter)
> - mempool_destroy(c->fill_iter);
> - if (c->bio_meta)
> - mempool_destroy(c->bio_meta);
> - if (c->search)
> - mempool_destroy(c->search);
> + mempool_destroy(c->fill_iter);
> + mempool_destroy(c->bio_meta);
> + mempool_destroy(c->search);
> kfree(c->devices);
>
> mutex_lock(&bch_register_lock);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org,
Neil Brown <neilb@suse.com>,
linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/39] bcache: drop null test before destroy functions
Date: Mon, 14 Sep 2015 09:08:18 +0000 [thread overview]
Message-ID: <mqdfv2hnzb1.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <1442146532-9100-16-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Sun, 13 Sep 2015 14:15:08 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> ---
> drivers/md/bcache/bset.c | 3 +--
> drivers/md/bcache/request.c | 3 +--
> drivers/md/bcache/super.c | 9 +++------
> 3 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 8e9877b..bd4678c 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1145,8 +1145,7 @@ void bch_flash_dev_request_init(struct bcache_device *d)
>
> void bch_request_exit(void)
> {
> - if (bch_search_cache)
> - kmem_cache_destroy(bch_search_cache);
> + kmem_cache_destroy(bch_search_cache);
> }
>
> int __init bch_request_init(void)
> diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
> index 646fe85..479117c 100644
> --- a/drivers/md/bcache/bset.c
> +++ b/drivers/md/bcache/bset.c
> @@ -1116,8 +1116,7 @@ struct bkey *bch_btree_iter_next_filter(struct btree_iter *iter,
>
> void bch_bset_sort_state_free(struct bset_sort_state *state)
> {
> - if (state->pool)
> - mempool_destroy(state->pool);
> + mempool_destroy(state->pool);
> }
>
> int bch_bset_sort_state_init(struct bset_sort_state *state, unsigned page_order)
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 679a093..c27a0ff 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1335,12 +1335,9 @@ static void cache_set_free(struct closure *cl)
> destroy_workqueue(c->moving_gc_wq);
> if (c->bio_split)
> bioset_free(c->bio_split);
> - if (c->fill_iter)
> - mempool_destroy(c->fill_iter);
> - if (c->bio_meta)
> - mempool_destroy(c->bio_meta);
> - if (c->search)
> - mempool_destroy(c->search);
> + mempool_destroy(c->fill_iter);
> + mempool_destroy(c->bio_meta);
> + mempool_destroy(c->search);
> kfree(c->devices);
>
> mutex_lock(&bch_register_lock);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2015-09-14 9:08 UTC|newest]
Thread overview: 163+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 12:14 [PATCH 00/39] drop null test before destroy functions Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` [Cluster-devel] " Julia Lawall
2015-09-13 12:14 ` [Intel-wired-lan] " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` [PATCH 01/39] mtd: nandsim: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-22 0:07 ` Brian Norris
2015-09-22 0:07 ` Brian Norris
2015-09-13 12:14 ` [PATCH 02/39] nilfs2: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-14 3:29 ` Ryusuke Konishi
2015-09-14 3:29 ` Ryusuke Konishi
2015-09-14 3:29 ` Ryusuke Konishi
2015-09-13 12:14 ` [PATCH 03/39] firmware: google: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` [PATCH 04/39] debugobjects: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` [PATCH 05/39] xhci: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-13 12:14 ` [PATCH 06/39] Btrfs: " Julia Lawall
2015-09-13 12:14 ` Julia Lawall
2015-09-14 20:43 ` David Sterba
2015-09-14 20:43 ` David Sterba
2015-09-13 12:15 ` [PATCH 07/39] fs: ext4: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 08/39] pktcdvd: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-29 13:02 ` Jiri Kosina
2015-09-29 13:02 ` Jiri Kosina
2015-09-13 12:15 ` [PATCH 09/39] aoe: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 1:39 ` Ed Cashin
2015-09-15 1:39 ` Ed Cashin
2015-09-13 12:15 ` [PATCH 10/39] atm: he: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 23:50 ` David Miller
2015-09-15 23:50 ` David Miller
2015-09-13 12:15 ` [PATCH 11/39] hfi1: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 13:56 ` Marciniszyn, Mike
2015-09-15 13:56 ` Marciniszyn, Mike
2015-09-13 12:15 ` [PATCH 12/39] dm: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 13:46 ` [dm-devel] " Mikulas Patocka
2015-09-14 13:46 ` Mikulas Patocka
2015-09-14 14:00 ` Mike Snitzer
2015-09-14 14:00 ` Mike Snitzer
2015-09-14 14:05 ` Mikulas Patocka
2015-09-14 14:05 ` Mikulas Patocka
2015-09-14 18:50 ` Julia Lawall
2015-09-14 18:50 ` Julia Lawall
2015-09-14 14:23 ` [dm-devel] " walter harms
2015-09-14 14:23 ` walter harms
2015-09-13 12:15 ` [PATCH 13/39] staging: lustre: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 14/39] SUNRPC: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 16:07 ` J. Bruce Fields
2015-09-14 16:07 ` J. Bruce Fields
2015-09-14 16:07 ` J. Bruce Fields
2015-09-14 16:25 ` Trond Myklebust
2015-09-14 16:25 ` Trond Myklebust
2015-09-13 12:15 ` [PATCH 15/39] bcache: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 9:08 ` Johannes Thumshirn [this message]
2015-09-14 9:08 ` Johannes Thumshirn
2015-09-13 12:15 ` [PATCH 16/39] usb: gadget: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 17/39] md: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 7:29 ` Neil Brown
2015-09-15 7:29 ` Neil Brown
2015-09-13 12:15 ` [PATCH 18/39] whci: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 19/39] jbd2: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 20/39] ixgbe: " Julia Lawall
2015-09-13 12:15 ` [Intel-wired-lan] " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 21/39] drbd: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 22/39] nfsd: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 16:06 ` J. Bruce Fields
2015-09-14 16:06 ` J. Bruce Fields
2015-09-13 12:15 ` [PATCH 23/39] UBI: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-10-03 18:36 ` Richard Weinberger
2015-10-03 18:36 ` Richard Weinberger
2015-09-13 12:15 ` [PATCH 24/39] dlm: " Julia Lawall
2015-09-13 12:15 ` [Cluster-devel] " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 25/39] net: core: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 23:50 ` David Miller
2015-09-15 23:50 ` David Miller
2015-09-13 12:15 ` [PATCH 26/39] dmaengine: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-21 17:10 ` Vinod Koul
2015-09-21 17:22 ` Vinod Koul
2015-09-13 12:15 ` [PATCH 27/39] ocfs2: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 28/39] ecryptfs: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 2:08 ` Tyler Hicks
2015-09-15 2:08 ` Tyler Hicks
2015-09-15 4:36 ` Julia Lawall
2015-09-15 4:36 ` Julia Lawall
2015-09-15 14:45 ` Tyler Hicks
2015-09-15 14:45 ` Tyler Hicks
2015-09-13 12:15 ` [PATCH 29/39] thunderbolt: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 30/39] block: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 31/39] KVM: MMU: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 8:30 ` Paolo Bonzini
2015-09-14 8:30 ` Paolo Bonzini
2015-09-13 12:15 ` [PATCH 32/39] drm: i915: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-30 8:44 ` [Intel-gfx] " Daniel Vetter
2015-09-30 8:44 ` Daniel Vetter
2015-09-30 8:44 ` Daniel Vetter
2015-09-13 12:15 ` [PATCH 33/39] rbd: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 9:53 ` Ilya Dryomov
2015-09-14 9:53 ` Ilya Dryomov
2015-09-13 12:15 ` [PATCH 34/39] dccp: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-15 23:50 ` David Miller
2015-09-15 23:50 ` David Miller
2015-09-15 23:50 ` David Miller
2015-09-13 12:15 ` [PATCH 35/39] GFS2: " Julia Lawall
2015-09-13 12:15 ` [Cluster-devel] " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 36/39] jffs2: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` [PATCH 37/39] f2fs crypto: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-16 10:17 ` Chao Yu
2015-09-16 10:17 ` Chao Yu
2015-09-16 10:17 ` Chao Yu
2015-09-13 12:15 ` [PATCH 38/39] iommu/amd: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-29 13:41 ` Joerg Roedel
2015-09-29 13:41 ` Joerg Roedel
2015-09-13 12:15 ` [PATCH 39/39] usb: host: " Julia Lawall
2015-09-13 12:15 ` Julia Lawall
2015-09-14 11:55 ` [PATCH 00/39] " SF Markus Elfring
2015-09-14 11:55 ` SF Markus Elfring
2015-09-14 11:55 ` [Cluster-devel] " SF Markus Elfring
2015-09-14 11:55 ` [Intel-wired-lan] " SF Markus Elfring
2015-09-14 11:55 ` SF Markus Elfring
2015-09-14 11:55 ` SF Markus Elfring
2015-09-14 11:55 ` SF Markus Elfring
2015-09-14 11:55 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqdfv2hnzb1.fsf@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=kent.overstreet@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.