From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv2 0/8] introduce automatic pool compaction
Date: Wed, 10 Jun 2015 09:04:53 +0900 [thread overview]
Message-ID: <20150610000453.GB13376@bgram> (raw)
In-Reply-To: <1433505838-23058-1-git-send-email-sergey.senozhatsky@gmail.com>
Hello Sergey,
Thanks for looking this and sorry for the delay for review.
I don't have a time to hold a review yet.
Please wait and I try to get a time within this week.
Thanks for your patience.
On Fri, Jun 05, 2015 at 09:03:50PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> This patch set tweaks compaction and makes it possible to trigger
> pool compaction automatically when system is getting low on memory.
>
> zsmalloc in some cases can suffer from a notable fragmentation and
> compaction can release some considerable amount of memory. The problem
> here is that currently we fully rely on user space to perform compaction
> when needed. However, performing zsmalloc compaction is not always an
> obvious thing to do. For example, suppose we have a `idle' fragmented
> (compaction was never performed) zram device and system is getting low
> on memory due to some 3rd party user processes (gcc LTO, or firefox, etc.).
> It's quite unlikely that user space will issue zpool compaction in this
> case. Besides, user space cannot tell for sure how badly pool is
> fragmented; however, this info is known to zsmalloc and, hence, to a
> shrinker.
>
> v2:
> -- use a slab shrinker instead of triggering compaction from zs_free (Minchan)
>
> Sergey Senozhatsky (8):
> zsmalloc: drop unused variable `nr_to_migrate'
> zsmalloc: partial page ordering within a fullness_list
> zsmalloc: lower ZS_ALMOST_FULL waterline
> zsmalloc: always keep per-class stats
> zsmalloc: introduce zs_can_compact() function
> zsmalloc: cosmetic compaction code adjustments
> zsmalloc/zram: move `num_migrated' to zs_pool
> zsmalloc: register a shrinker to trigger auto-compaction
>
> drivers/block/zram/zram_drv.c | 12 +--
> drivers/block/zram/zram_drv.h | 1 -
> include/linux/zsmalloc.h | 1 +
> mm/zsmalloc.c | 228 +++++++++++++++++++++++++++---------------
> 4 files changed, 152 insertions(+), 90 deletions(-)
>
> --
> 2.4.2.387.gf86f31a
>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv2 0/8] introduce automatic pool compaction
Date: Wed, 10 Jun 2015 09:04:53 +0900 [thread overview]
Message-ID: <20150610000453.GB13376@bgram> (raw)
In-Reply-To: <1433505838-23058-1-git-send-email-sergey.senozhatsky@gmail.com>
Hello Sergey,
Thanks for looking this and sorry for the delay for review.
I don't have a time to hold a review yet.
Please wait and I try to get a time within this week.
Thanks for your patience.
On Fri, Jun 05, 2015 at 09:03:50PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> This patch set tweaks compaction and makes it possible to trigger
> pool compaction automatically when system is getting low on memory.
>
> zsmalloc in some cases can suffer from a notable fragmentation and
> compaction can release some considerable amount of memory. The problem
> here is that currently we fully rely on user space to perform compaction
> when needed. However, performing zsmalloc compaction is not always an
> obvious thing to do. For example, suppose we have a `idle' fragmented
> (compaction was never performed) zram device and system is getting low
> on memory due to some 3rd party user processes (gcc LTO, or firefox, etc.).
> It's quite unlikely that user space will issue zpool compaction in this
> case. Besides, user space cannot tell for sure how badly pool is
> fragmented; however, this info is known to zsmalloc and, hence, to a
> shrinker.
>
> v2:
> -- use a slab shrinker instead of triggering compaction from zs_free (Minchan)
>
> Sergey Senozhatsky (8):
> zsmalloc: drop unused variable `nr_to_migrate'
> zsmalloc: partial page ordering within a fullness_list
> zsmalloc: lower ZS_ALMOST_FULL waterline
> zsmalloc: always keep per-class stats
> zsmalloc: introduce zs_can_compact() function
> zsmalloc: cosmetic compaction code adjustments
> zsmalloc/zram: move `num_migrated' to zs_pool
> zsmalloc: register a shrinker to trigger auto-compaction
>
> drivers/block/zram/zram_drv.c | 12 +--
> drivers/block/zram/zram_drv.h | 1 -
> include/linux/zsmalloc.h | 1 +
> mm/zsmalloc.c | 228 +++++++++++++++++++++++++++---------------
> 4 files changed, 152 insertions(+), 90 deletions(-)
>
> --
> 2.4.2.387.gf86f31a
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-10 0:04 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 12:03 [RFC][PATCHv2 0/8] introduce automatic pool compaction Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 1/8] zsmalloc: drop unused variable `nr_to_migrate' Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 2/8] zsmalloc: partial page ordering within a fullness_list Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-16 13:19 ` Minchan Kim
2015-06-16 13:19 ` Minchan Kim
2015-06-16 14:30 ` Sergey Senozhatsky
2015-06-16 14:30 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 3/8] zsmalloc: lower ZS_ALMOST_FULL waterline Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-16 13:37 ` Minchan Kim
2015-06-16 13:37 ` Minchan Kim
2015-06-16 14:35 ` Sergey Senozhatsky
2015-06-16 14:35 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 4/8] zsmalloc: always keep per-class stats Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 5/8] zsmalloc: introduce zs_can_compact() function Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-16 14:19 ` Minchan Kim
2015-06-16 14:19 ` Minchan Kim
2015-06-16 14:41 ` Sergey Senozhatsky
2015-06-16 14:41 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 6/8] zsmalloc: cosmetic compaction code adjustments Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 7/8] zsmalloc/zram: move `num_migrated' to zs_pool Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-05 12:03 ` [RFC][PATCHv2 8/8] zsmalloc: register a shrinker to trigger auto-compaction Sergey Senozhatsky
2015-06-05 12:03 ` Sergey Senozhatsky
2015-06-16 14:47 ` Minchan Kim
2015-06-16 14:47 ` Minchan Kim
2015-06-16 15:45 ` Sergey Senozhatsky
2015-06-16 15:45 ` Sergey Senozhatsky
2015-06-18 1:50 ` Minchan Kim
2015-06-18 1:50 ` Minchan Kim
2015-06-18 2:41 ` Sergey Senozhatsky
2015-06-18 2:41 ` Sergey Senozhatsky
2015-06-18 3:01 ` Sergey Senozhatsky
2015-06-18 3:01 ` Sergey Senozhatsky
2015-06-18 3:46 ` Minchan Kim
2015-06-18 3:46 ` Minchan Kim
2015-06-18 3:39 ` Minchan Kim
2015-06-18 3:39 ` Minchan Kim
2015-06-18 3:58 ` Sergey Senozhatsky
2015-06-18 3:58 ` Sergey Senozhatsky
2015-06-17 7:11 ` Sergey Senozhatsky
2015-06-17 7:11 ` Sergey Senozhatsky
2015-06-10 0:04 ` Minchan Kim [this message]
2015-06-10 0:04 ` [RFC][PATCHv2 0/8] introduce automatic pool compaction Minchan Kim
2015-06-10 0:07 ` Sergey Senozhatsky
2015-06-10 0:07 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610000453.GB13376@bgram \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.