All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt
@ 2015-06-17 14:46 Thomas de Beauchene
  2015-06-17 14:54 ` Jonathan Corbet
  2015-06-22 16:13 ` Jonathan Corbet
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas de Beauchene @ 2015-06-17 14:46 UTC (permalink / raw)
  To: corbet; +Cc: linux-doc, linux-kernel, Thomas de Beauchene, Thomas de Beauchene

Updated struct inode_operations documentation in vfs.txt to match
current implementation

Signed-off-by: Thomas de Beauchene <chauvo_t@epitech.eu>
---
 Documentation/filesystems/vfs.txt | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
index 3cb2ccf..ff53e34 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -341,11 +341,18 @@ struct inode_operations
 -----------------------
 
 This describes how the VFS can manipulate an inode in your
-filesystem. As of kernel 2.6.22, the following members are defined:
+filesystem. As of kernel 4.1, the following members are defined:
 
 struct inode_operations {
-	int (*create) (struct inode *,struct dentry *, umode_t, bool);
 	struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);
+	void * (*follow_link) (struct dentry *, struct nameidata *);
+	int (*permission) (struct inode *, int);
+	struct posix_acl * (*get_acl)(struct inode *, int);
+
+	int (*readlink) (struct dentry *, char __user *,int);
+	void (*put_link) (struct dentry *, struct nameidata *, void *);
+
+	int (*create) (struct inode *,struct dentry *, umode_t, bool);
 	int (*link) (struct dentry *,struct inode *,struct dentry *);
 	int (*unlink) (struct inode *,struct dentry *);
 	int (*symlink) (struct inode *,struct dentry *,const char *);
@@ -356,23 +363,24 @@ struct inode_operations {
 			struct inode *, struct dentry *);
 	int (*rename2) (struct inode *, struct dentry *,
 			struct inode *, struct dentry *, unsigned int);
-	int (*readlink) (struct dentry *, char __user *,int);
-        void * (*follow_link) (struct dentry *, struct nameidata *);
-        void (*put_link) (struct dentry *, struct nameidata *, void *);
-	int (*permission) (struct inode *, int);
-	int (*get_acl)(struct inode *, int);
 	int (*setattr) (struct dentry *, struct iattr *);
 	int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *);
 	int (*setxattr) (struct dentry *, const char *,const void *,size_t,int);
 	ssize_t (*getxattr) (struct dentry *, const char *, void *, size_t);
 	ssize_t (*listxattr) (struct dentry *, char *, size_t);
 	int (*removexattr) (struct dentry *, const char *);
-	void (*update_time)(struct inode *, struct timespec *, int);
-	int (*atomic_open)(struct inode *, struct dentry *, struct file *,
-			unsigned open_flag, umode_t create_mode, int *opened);
+	int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start,
+		      u64 len);
+	int (*update_time)(struct inode *, struct timespec *, int);
+	int (*atomic_open)(struct inode *, struct dentry *,
+			   struct file *, unsigned open_flag,
+			   umode_t create_mode, int *opened);
 	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
+	int (*set_acl)(struct inode *, struct posix_acl *, int);
+
+	/* WARNING: probably going away soon, do not use! */
 	int (*dentry_open)(struct dentry *, struct file *, const struct cred *);
-};
+} ____cacheline_aligned;
 
 Again, all methods are called without any locks being held, unless
 otherwise noted.
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt
  2015-06-17 14:46 [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt Thomas de Beauchene
@ 2015-06-17 14:54 ` Jonathan Corbet
  2015-06-17 15:04   ` Al Viro
  2015-06-22 16:13 ` Jonathan Corbet
  1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2015-06-17 14:54 UTC (permalink / raw)
  To: Thomas de Beauchene; +Cc: linux-doc, linux-kernel, Thomas de Beauchene, Al Viro

On Wed, 17 Jun 2015 16:46:35 +0200
Thomas de Beauchene <thomas.chauvot-de-beauchene@epitech.eu> wrote:

> Updated struct inode_operations documentation in vfs.txt to match
> current implementation

Looks good at a first glance, will probably queue it later.  But please be
sure to CC Al Viro (added) on patches like this; he's the expert in this
area.

Thanks,

jon

> Signed-off-by: Thomas de Beauchene <chauvo_t@epitech.eu>
> ---
>  Documentation/filesystems/vfs.txt | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
> index 3cb2ccf..ff53e34 100644
> --- a/Documentation/filesystems/vfs.txt
> +++ b/Documentation/filesystems/vfs.txt
> @@ -341,11 +341,18 @@ struct inode_operations
>  -----------------------
>  
>  This describes how the VFS can manipulate an inode in your
> -filesystem. As of kernel 2.6.22, the following members are defined:
> +filesystem. As of kernel 4.1, the following members are defined:
>  
>  struct inode_operations {
> -	int (*create) (struct inode *,struct dentry *, umode_t, bool);
>  	struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);
> +	void * (*follow_link) (struct dentry *, struct nameidata *);
> +	int (*permission) (struct inode *, int);
> +	struct posix_acl * (*get_acl)(struct inode *, int);
> +
> +	int (*readlink) (struct dentry *, char __user *,int);
> +	void (*put_link) (struct dentry *, struct nameidata *, void *);
> +
> +	int (*create) (struct inode *,struct dentry *, umode_t, bool);
>  	int (*link) (struct dentry *,struct inode *,struct dentry *);
>  	int (*unlink) (struct inode *,struct dentry *);
>  	int (*symlink) (struct inode *,struct dentry *,const char *);
> @@ -356,23 +363,24 @@ struct inode_operations {
>  			struct inode *, struct dentry *);
>  	int (*rename2) (struct inode *, struct dentry *,
>  			struct inode *, struct dentry *, unsigned int);
> -	int (*readlink) (struct dentry *, char __user *,int);
> -        void * (*follow_link) (struct dentry *, struct nameidata *);
> -        void (*put_link) (struct dentry *, struct nameidata *, void *);
> -	int (*permission) (struct inode *, int);
> -	int (*get_acl)(struct inode *, int);
>  	int (*setattr) (struct dentry *, struct iattr *);
>  	int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *);
>  	int (*setxattr) (struct dentry *, const char *,const void *,size_t,int);
>  	ssize_t (*getxattr) (struct dentry *, const char *, void *, size_t);
>  	ssize_t (*listxattr) (struct dentry *, char *, size_t);
>  	int (*removexattr) (struct dentry *, const char *);
> -	void (*update_time)(struct inode *, struct timespec *, int);
> -	int (*atomic_open)(struct inode *, struct dentry *, struct file *,
> -			unsigned open_flag, umode_t create_mode, int *opened);
> +	int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start,
> +		      u64 len);
> +	int (*update_time)(struct inode *, struct timespec *, int);
> +	int (*atomic_open)(struct inode *, struct dentry *,
> +			   struct file *, unsigned open_flag,
> +			   umode_t create_mode, int *opened);
>  	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
> +	int (*set_acl)(struct inode *, struct posix_acl *, int);
> +
> +	/* WARNING: probably going away soon, do not use! */
>  	int (*dentry_open)(struct dentry *, struct file *, const struct cred *);
> -};
> +} ____cacheline_aligned;
>  
>  Again, all methods are called without any locks being held, unless
>  otherwise noted.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt
  2015-06-17 14:54 ` Jonathan Corbet
@ 2015-06-17 15:04   ` Al Viro
  0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2015-06-17 15:04 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Thomas de Beauchene, linux-doc, linux-kernel, Thomas de Beauchene

On Wed, Jun 17, 2015 at 08:54:07AM -0600, Jonathan Corbet wrote:
> On Wed, 17 Jun 2015 16:46:35 +0200
> Thomas de Beauchene <thomas.chauvot-de-beauchene@epitech.eu> wrote:
> 
> > Updated struct inode_operations documentation in vfs.txt to match
> > current implementation
> 
> Looks good at a first glance, will probably queue it later.  But please be
> sure to CC Al Viro (added) on patches like this; he's the expert in this
> area.

... and check -next, for that matter.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt
  2015-06-17 14:46 [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt Thomas de Beauchene
  2015-06-17 14:54 ` Jonathan Corbet
@ 2015-06-22 16:13 ` Jonathan Corbet
  1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2015-06-22 16:13 UTC (permalink / raw)
  To: Thomas de Beauchene; +Cc: linux-doc, linux-kernel, Thomas de Beauchene

On Wed, 17 Jun 2015 16:46:35 +0200
Thomas de Beauchene <thomas.chauvot-de-beauchene@epitech.eu> wrote:

> Updated struct inode_operations documentation in vfs.txt to match
> current implementation

This one conflicts against changes made in the vfs tree.  Could you
please regenerate it against -next (or, better, against mainline once
Al's tree is merged)?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-06-22 16:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-17 14:46 [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt Thomas de Beauchene
2015-06-17 14:54 ` Jonathan Corbet
2015-06-17 15:04   ` Al Viro
2015-06-22 16:13 ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.